Bug 376617 - Odd behaviour of sidebar buttons under some themes (Adwaita-Qt)
Summary: Odd behaviour of sidebar buttons under some themes (Adwaita-Qt)
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Themes (show other bugs)
Version: 5.4.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-18 15:03 UTC by Craig Drummond
Modified: 2022-01-13 06:11 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 7.5.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Craig Drummond 2017-02-18 15:03:07 UTC
DMultiTabBarTab::initStyleOption() only sets QStyle::State_AutoRaise flag if the sidebar button is under the mouse. I think this is incorrect, in that the button is always 'AutoRaise' - just it should only be drawn raised if under the mouse or pressed, etc. Its AutoRaise property should be static.

This caused issues with the Qt version of Adwaita - the text of the buttons would change from being elided to not when the mouse hovered over. This was partly due to an issue with Adwaita - it contained different metrics for auto-rasie toolbuttons (I have submitted a pull request to fix this). However, as stated above I think this flag should be set for all cases.
Comment 1 caulier.gilles 2017-02-18 15:51:43 UTC
A quick patch to fix this behavior will be welcome...

Gilles Caulier
Comment 2 caulier.gilles 2020-08-02 12:49:51 UTC
digiKam 7.0.0 stable release is now published:

https://www.digikam.org/news/2020-07-19-7.0.0_release_announcement/

We need a fresh feedback on this file using this version.

Best Reagrds

Gilles Caulier
Comment 3 caulier.gilles 2022-01-10 13:07:33 UTC
Hi Craig and happy new year,

Can you check if problem remain with digiKam 7.5.0 pre-release bundle available
here :

https://files.kde.org/digikam/

Thanks in advance

Gilles Caulier
Comment 4 caulier.gilles 2022-01-13 06:11:26 UTC
Git commit 210c04de36bdb90c130b032b1b92f9a4cee62183 by Gilles Caulier.
Committed on 13/01/2022 at 06:10.
Pushed by cgilles into branch 'master'.

fix sidebar button behavior
FIXED-IN: 7.5.0

M  +11   -4    core/libs/widgets/layout/sidebar.cpp

https://invent.kde.org/graphics/digikam/commit/210c04de36bdb90c130b032b1b92f9a4cee62183