Bug 376405 - Saturation value in HSV adjustment isn't restored
Summary: Saturation value in HSV adjustment isn't restored
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Filter Layers (show other bugs)
Version: 3.1.2
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-12 17:07 UTC by Alex
Modified: 2018-01-05 08:56 UTC (History)
3 users (show)

See Also:
Latest Commit: https://commits.kde.org/krita/581b87f6469894f6c7ee1d2f19bbf34883b869be
Version Fixed In:
Sentry Crash Report:

Attachments
Fix for incorrect restoration of saturation slider (1.33 KB, patch)
2017-04-12 21:24 UTC, RKS 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2017-02-12 17:07:05 UTC 
It is stored in filter layer but when layer parameters are edited again saturation is reset to 0.
Comment 1 Nicholas LaPointe 2017-02-15 10:43:29 UTC 
Thanks for your report! I am able to reproduce the issue.
Comment 2 RKS 2017-04-12 21:24:22 UTC 
Created attachment 104998 [details]
Fix for incorrect restoration of saturation slider

In the UI file (wdg_hsv_adjustment.ui), the minimum value for saturationSpinBox was not set, and hence was taken as default 0, and the minimum value for saturationSlider was set to 0.

I added them and now it seems to work fine.
Comment 3 Halla Rempt 2017-04-25 12:39:50 UTC 
Thanks for the patch!
Comment 4 Halla Rempt 2017-04-25 12:39:51 UTC 
Git commit 581b87f6469894f6c7ee1d2f19bbf34883b869be by Boudewijn Rempt.
Committed on 25/04/2017 at 12:38.
Pushed by rempt into branch 'master'.

This fixes loading a hsv adjustment from a filter layer and editing
them.

M  +5    -2    plugins/filters/colorsfilters/wdg_hsv_adjustment.ui

https://commits.kde.org/krita/581b87f6469894f6c7ee1d2f19bbf34883b869be
Comment 5 Halla Rempt 2017-06-16 19:58:25 UTC 
Can still be reproduced.
Comment 6 Alex 2018-01-04 23:34:26 UTC 
I've checked current 4.0 alpha and it seems to work fine.
Comment 7 Halla Rempt 2018-01-05 08:56:05 UTC 
Okay, closing.