Bug 376351 - create a tool to automatically group jpeg and raw images with same name
Summary: create a tool to automatically group jpeg and raw images with same name
Status: RESOLVED WORKSFORME
Alias: None
Product: digikam
Classification: Applications
Component: Albums-ItemGroup (show other bugs)
Version: 5.4.0
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-11 13:31 UTC by Karsten de Freese
Modified: 2017-02-13 18:04 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.5.0
Sentry Crash Report:


Attachments
rename type -> filename (6.49 KB, patch)
2017-02-11 14:47 UTC, Simon
Details
Updated doc with "Group By Filename" (3.17 KB, patch)
2017-02-12 14:40 UTC, Barbara Scheffner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karsten de Freese 2017-02-11 13:31:30 UTC
hi digikam team,

I've just moved my photo collection from shotwell to digikam, for the fantastic number of interesting features, and most importantly, the option to use a central mysql database.
There's one thing Iā€™m missing though, and I may very well just not have found out how to do it: I'd like to group jpeg and raw files of the same photo, as I usually have my camera set to produce both formats for each shot.
With my existing photo collection, it's not really feasible to do this by hand.
I've seen ticket 126149, but I'm not able to find the functionality I understand from this ticket in digikam 5.4 - instead, grouping images by file type (view/group pictures/by format) just separates them into two lists for jpeg and raw.

So what am I looking for:
- a way to combine files with same filename, but different 'picture type'
  extensions into a group (in my & similar cases it will be exactly two
  files with the same date/time, and extensions .JPG and e.g. .ORF)
- either put the .JPG on top or make it configurable
- this could be done automatically for all jpeg/raw pairs
  (I understand that this is what is described in 126149?)
- or as a BQM tool to be run manually
  (in this case, ideally this functionality should also be available
   during image download)

There are quite some similar feature requests, most already resolved, so please excuse me if I just don't see the obvious..

thanks for looking into this -
Karsten
Comment 1 Simon 2017-02-11 14:47:17 UTC
Created attachment 103980 [details]
rename type -> filename

This is already possible: Select all items you want to group, in the context menu select group -> group selected by type. This is however wrongly named, as the resulting groups do not contain files with the same type but files with the same filename excluding extension. This discussion has already happened, but I can't find a bug report - I assume it was on the user mailing list.

The attached patch renames the UI string and the involved methods: type -> filename. Gilles, Maik or Mario (or anyone else) do you agree?
Comment 2 Maik Qualmann 2017-02-11 14:55:04 UTC
Yes, I agree. File name is more logical.

Maik
Comment 3 caulier.gilles 2017-02-11 15:10:19 UTC
Fine for me too...

Gilles
Comment 4 Simon 2017-02-11 15:23:44 UTC
I committed this but borked up the CCBUG part, so here is the link to
the commit:
https://cgit.kde.org/digikam.git/commit/?id=4a2ef6c03aeebf37f7515a6d6c37d971d609443
Comment 5 Karsten de Freese 2017-02-12 11:45:29 UTC
thanks for the quick help!
'context menu select group -> group selected by type' did exactly what I was looking for.
This function did not catch my attention before, probably because I was assuming that it would do the same thing as 'view -> group pictures -> by format', instead of the slightly different wording.
With the changed UI string this will certainly be more obvious..!
Comment 6 Barbara Scheffner 2017-02-12 14:40:57 UTC
Created attachment 104004 [details]
Updated doc with "Group By Filename"

I updated the doc accordingly (see patch attached).
Whoever would like to commit it on my behalf (Gilles, Maik, Simon): feel free!
Updated screenshot follows once the changes are in the AppImage.
Comment 7 Barbara Scheffner 2017-02-12 14:50:25 UTC
Simon,

just for me to learn: why did you set "WORKSFORME" and not "FIXED"?

Wolfgang


Am 12.02.2017 um 12:11 schrieb Simon:
> https://bugs.kde.org/show_bug.cgi?id=376351
>
> Simon <freisim93@gmail.com> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>          Resolution|---                         |WORKSFORME
>              Status|UNCONFIRMED                 |RESOLVED
>
Comment 8 Simon 2017-02-12 14:56:36 UTC
Hi Wolfgang,

Better don't learn from me in this regard - I am still learning myself.
I can still give you my reasoning of course: This issue was asking about
functionality that was already there. My commit that renamed this
functionality did not fix the issue, while it was obviously related to
this issue. So I was wondering whether I should file it as "invalid" or
"worksforme". I decided for the latter, as the requested functionality
is sound (i.e. not invalid), we just have it already (it works for me).
In the end I figured the most important part is to close the issue, the
reason is kind of secondary.

Cheers,
Simon
Comment 9 caulier.gilles 2017-02-13 18:04:34 UTC
Git commit 875ac9bef9d0745b3f67e52de115b7008f580c11 by Gilles Caulier.
Committed on 13/02/2017 at 18:03.
Pushed by cgilles into branch 'master'.

apply patch #104004 to implement Group by filename in digiKam handbook

M  +2    -2    digikam/using-mainwindow-imageview.docbook

https://commits.kde.org/digikam-doc/875ac9bef9d0745b3f67e52de115b7008f580c11