Bug 376214 - layer sometimes says "group not editable"
Summary: layer sometimes says "group not editable"
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Layer Stack (show other bugs)
Version: unspecified
Platform: Other Microsoft Windows
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 376215 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-09 00:58 UTC by rianisbae
Modified: 2017-04-20 15:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
you can see what happens when i try to draw (272.03 KB, image/png)
2017-02-09 00:58 UTC, rianisbae
Details

Note You need to log in before you can comment on or make changes to this bug.
Description rianisbae 2017-02-09 00:58:08 UTC
Created attachment 103911 [details]
you can see what happens when i try to draw

sometimes when i am drawing on a SINGULAR layer and i try to draw on it it will say "group not editable". this is on a SINGULAR layer!
Comment 1 Halla Rempt 2017-02-09 14:01:57 UTC

*** This bug has been marked as a duplicate of bug 376215 ***
Comment 2 Halla Rempt 2017-02-09 14:02:46 UTC
*** Bug 376215 has been marked as a duplicate of this bug. ***
Comment 3 Halla Rempt 2017-02-09 14:03:13 UTC
I've seen this happen too, but no idea why it happens...
Comment 4 Dmitry Kazakov 2017-04-20 13:11:12 UTC
Most probably, the bug happens because one of the parents of the layer is not editable (locked or invisible). Probably, we should make the message a bit more verbose.
Comment 5 Dmitry Kazakov 2017-04-20 13:15:30 UTC
Hmm.. on a screenshot there seem to be no parent exist :(
Comment 6 Dmitry Kazakov 2017-04-20 13:16:52 UTC
Ok, I managed to reproduce it: interleaving quick brush strokes with pressing PgUp and PgDown layer switch shortcuts triggers the bug.
Comment 7 Dmitry Kazakov 2017-04-20 14:40:25 UTC
Git commit 9c57c307302e224edebd87413e86058503205311 by Dmitry Kazakov.
Committed on 20/04/2017 at 14:22.
Pushed by dkazakov into branch 'krita/3.1'.

Use blockUntilOperationsFinished instead of setSystemLocked()

This patch effectively removes all the setSystemLocked
functionality. It was not used properly for several years
already, because all its work is now delegated to the
strokes framework.

M  +2    -19   libs/image/kis_base_node.cpp
M  +0    -23   libs/image/kis_base_node.h
D  +0    -43   libs/image/kis_system_locker.h
M  +0    -1    libs/ui/flake/kis_node_shape.cpp
M  +4    -3    libs/ui/kis_node_manager.cpp
M  +17   -11   libs/ui/tool/kis_tool.cc
M  +3    -3    libs/ui/tool/kis_tool.h
M  +0    -3    libs/ui/tool/kis_tool_freehand.cc
M  +1    -1    libs/ui/tool/kis_tool_paint.cc
M  +1    -4    libs/ui/tool/kis_tool_shape.cc
M  +1    -3    plugins/tools/basictools/kis_tool_ellipse.cc
M  +0    -1    plugins/tools/basictools/kis_tool_fill.cc
M  +1    -4    plugins/tools/basictools/kis_tool_gradient.cc
M  +1    -3    plugins/tools/basictools/kis_tool_rectangle.cc
M  +0    -1    plugins/tools/selectiontools/kis_tool_select_elliptical.cc
M  +0    -1    plugins/tools/selectiontools/kis_tool_select_polygonal.cc
M  +0    -1    plugins/tools/selectiontools/kis_tool_select_rectangular.cc
M  +2    -2    plugins/tools/tool_polygon/kis_tool_polygon.cc
M  +2    -2    plugins/tools/tool_polyline/kis_tool_polyline.cc
M  +0    -1    plugins/tools/tool_transform2/kis_tool_transform.cc

https://commits.kde.org/krita/9c57c307302e224edebd87413e86058503205311
Comment 8 Dmitry Kazakov 2017-04-20 15:14:46 UTC
Git commit a317eeda8b9464e0e775518eb98909db73c53eee by Dmitry Kazakov.
Committed on 20/04/2017 at 15:14.
Pushed by dkazakov into branch 'master'.

Use blockUntilOperationsFinished instead of setSystemLocked()

This patch effectively removes all the setSystemLocked
functionality. It was not used properly for several years
already, because all its work is now delegated to the
strokes framework.

M  +2    -16   libs/image/kis_base_node.cpp
M  +0    -23   libs/image/kis_base_node.h
D  +0    -43   libs/image/kis_system_locker.h
M  +1    -1    libs/libkis/Node.cpp
M  +1    -1    libs/ui/KisImageBarrierLockerWithFeedback.cpp
M  +1    -1    libs/ui/KisView.cpp
M  +1    -1    libs/ui/KisViewManager.cpp
M  +3    -3    libs/ui/KisViewManager.h
M  +2    -2    libs/ui/canvas/kis_canvas2.cpp
M  +1    -1    libs/ui/dialogs/KisAnimationCacheUpdateProgressDialog.cpp
M  +0    -1    libs/ui/flake/kis_node_shape.cpp
M  +4    -3    libs/ui/kis_node_manager.cpp
M  +17   -11   libs/ui/tool/kis_tool.cc
M  +3    -3    libs/ui/tool/kis_tool.h
M  +0    -3    libs/ui/tool/kis_tool_freehand.cc
M  +1    -1    libs/ui/tool/kis_tool_paint.cc
M  +1    -4    libs/ui/tool/kis_tool_shape.cc
M  +1    -3    plugins/tools/basictools/kis_tool_ellipse.cc
M  +0    -1    plugins/tools/basictools/kis_tool_fill.cc
M  +1    -4    plugins/tools/basictools/kis_tool_gradient.cc
M  +1    -3    plugins/tools/basictools/kis_tool_rectangle.cc
M  +0    -1    plugins/tools/selectiontools/kis_tool_select_elliptical.cc
M  +0    -1    plugins/tools/selectiontools/kis_tool_select_polygonal.cc
M  +0    -1    plugins/tools/selectiontools/kis_tool_select_rectangular.cc
M  +2    -2    plugins/tools/tool_polygon/kis_tool_polygon.cc
M  +2    -2    plugins/tools/tool_polyline/kis_tool_polyline.cc
M  +0    -1    plugins/tools/tool_transform2/kis_tool_transform.cc

https://commits.kde.org/krita/a317eeda8b9464e0e775518eb98909db73c53eee