Bug 376199 - task manager and digital clock plasmoids do not work with Qt5.6 because of missing QtQuick2.7 dependency
Summary: task manager and digital clock plasmoids do not work with Qt5.6 because of mi...
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (show other bugs)
Version: 5.9.0
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-08 20:04 UTC by .
Modified: 2017-02-09 10:23 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description . 2017-02-08 20:04:04 UTC
After I upgraded KDE Plasma from 5.8.x to 5.9.0, I quickly noticed that the digital clock and taskbar plasmoids stopped working. Hovering over them told me that QtQuick 2.7 is missing. So I grepped over all plasmoids and it revealed that these files:

    /usr/share/plasma/plasmoids/org.kde.plasma.digitalclock/contents/ui/DigitalClock.qml
    /usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/ToolTipInstance.qml
    /usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/ToolTipDelegate.qml

contain line:

    import QtQuick 2.7

So I used in-place sed to change it to:

    import QtQuick 2.6

and it started working again.


Commits that introduced QtQuick 2.7:

for digital clock:
https://github.com/KDE/plasma-workspace/commit/1d362c4ae2e264a80c002ab6718c1b1d9437c20c

for task manager:
https://github.com/KDE/plasma-desktop/commit/4f9198fc5f21334b989575c3d9891254d0b1e185


Btw is the minimal Qt version still 5.5 as noted here - https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/OwnQt5#Use_Qt5_Distribution_Packages?
Comment 1 Eike Hein 2017-02-09 08:26:28 UTC
Roman, do you need 2.7 in TM?
Comment 2 David Edmundson 2017-02-09 09:53:28 UTC
The minimum version is Qt 5.6, the root CmakeLists.txt is always the most accurate resource.

This is still wrong though, will fix.
Comment 3 David Edmundson 2017-02-09 09:58:10 UTC
Git commit 1e9a3875e5bda036bd2060aaedc57932edface72 by David Edmundson.
Committed on 09/02/2017 at 09:56.
Pushed by davidedmundson into branch 'Plasma/5.9'.

Match QtQuick import to minimum Qt version

We require Qt 5.6, import for Qt5.6 is 2.6

M  +1    -1    applets/digital-clock/package/contents/ui/DigitalClock.qml

https://commits.kde.org/plasma-workspace/1e9a3875e5bda036bd2060aaedc57932edface72
Comment 4 Kai Uwe Broulik 2017-02-09 10:05:24 UTC
Git commit 5bbedd2c9f61dace6ffc62d993d03adff3063b4d by Kai Uwe Broulik.
Committed on 09/02/2017 at 10:05.
Pushed by broulik into branch 'Plasma/5.9'.

[Task Manager] Don't import QtQuick 2.7

We don't make use of any new properties and we still support Qt 5.6 in Plasma 5.9 apparently.

Reviewed-By: David Edmundson

Differential Revision: https://phabricator.kde.org/D4520

M  +1    -1    applets/taskmanager/package/contents/ui/ToolTipDelegate.qml
M  +1    -1    applets/taskmanager/package/contents/ui/ToolTipInstance.qml

https://commits.kde.org/plasma-desktop/5bbedd2c9f61dace6ffc62d993d03adff3063b4d