Bug 376196 - Some windows in kaffeine have "OK" and "Cancel" instead of just "Close".
Summary: Some windows in kaffeine have "OK" and "Cancel" instead of just "Close".
Status: RESOLVED FIXED
Alias: None
Product: kaffeine
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Other Linux
: NOR minor
Target Milestone: ---
Assignee: Mauro Carvalho Chehab
URL:
Keywords: junior-jobs
Depends on:
Blocks:
 
Reported: 2017-02-08 18:34 UTC by yulinux
Modified: 2017-02-15 11:39 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description yulinux 2017-02-08 18:34:49 UTC
Hello, 
I think since kaffeine is adjusted to KF5 (so from kaffeine 2 on), there are some windows (e.g. the EPG window and the program schedule next to it) that show the possibilities to "Cancel" and "OK". But there is no difference between pressing "Cancel" and "OK", so if you e.g. plan a record and press afterwards cancel, the record is saved nonetheless. This is a bit confusing. I think in earlier versions those windows just had a "Close" button. Thanks. :)
Comment 1 Mauro Carvalho Chehab 2017-02-15 09:44:36 UTC
(In reply to yulinux from comment #0)
> Hello, 
> I think since kaffeine is adjusted to KF5 (so from kaffeine 2 on), there are
> some windows (e.g. the EPG window and the program schedule next to it) that
> show the possibilities to "Cancel" and "OK". But there is no difference
> between pressing "Cancel" and "OK", so if you e.g. plan a record and press
> afterwards cancel, the record is saved nonetheless. This is a bit confusing.
> I think in earlier versions those windows just had a "Close" button. Thanks.
> :)

On several such windows, clicking at the (X) button on the top of the windows (on Kaffeine 1.x) used to cancel the dialog. On Kaffeine 2.x, it should be doing the same with either (x) or <cancel> button.

The expected behavior is that, by clicking at <cancel> will discard the changes done at that specific window.

Perhaps on a few dialogs, the <cancel> is not doing the right thing. I'll double check.
Comment 2 Mauro Carvalho Chehab 2017-02-15 11:39:12 UTC
(In reply to Mauro Carvalho Chehab from comment #1)
> (In reply to yulinux from comment #0)

> The expected behavior is that, by clicking at <cancel> will discard the
> changes done at that specific window.
> 
> Perhaps on a few dialogs, the <cancel> is not doing the right thing. I'll
> double check.

Changed two dialogs to use <close> button instead of OK/Cancel:
   - Record Schedule dialog;
   - Program Guide dialog.