Bug 376090 - When finding in folder, remember search bar mode across restarts
Summary: When finding in folder, remember search bar mode across restarts
Status: RESOLVED WORKSFORME
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: Git
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-06 09:12 UTC by Wladimir Palant
Modified: 2018-05-06 00:15 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wladimir Palant 2017-02-06 09:12:05 UTC
The default for "Find in folder" is currently "search." While this probably makes sense, personally I prefer Total Commander's default which is "filter." As things are right now (2.5.1-beta build, revision 5056272), I have to switch modes every time I restart Krusader or create a new tab. It would be better if search bar mode were a stored tab setting so that it would be restored on startup and could be saved as default for new tabs.

Note that there is currently an "Open search filter" action that one can configure a keyboard shortcut for. This feature appears to be merely a workaround for search bar mode not being remembered - you cannot really use both "Open search filter" and "Find in tab" because the former will switch search bar mode to "filter" and that's what you will get the next time you try to use "Find in tab." So IMHO this feature should be removed in the same go.

I plan to implement this but I need to wait for a decision on the right approach in https://phabricator.kde.org/D4418 first.
Comment 1 Wladimir Palant 2017-02-06 09:22:45 UTC
(In reply to Wladimir Palant from comment #0)
> Note that there is currently an "Open search filter" action that one can
> configure a keyboard shortcut for. This feature appears to be merely a
> workaround for search bar mode not being remembered

I checked the history and this was apparently introduced in https://phabricator.kde.org/D2105. So this is merely a backwards compatibility feature which no longer makes sense - originally "Quick filter" was a separate widget that didn't affect search.
Comment 2 Alex Bikadorov 2017-02-06 17:35:35 UTC
> The default for "Find in folder" is currently "search." While this probably makes sense, personally I prefer Total Commander's default which is "filter." As things are right now (2.5.1-beta build, revision 5056272), I have to switch modes every time I restart Krusader or create a new tab.

Have you seen Krusader settings->Panel->General:Search Bar:Default Mode?

>Note that there is currently an "Open search filter" action that one can configure a keyboard shortcut for.

I left this how it was only for backwards compatibility. Those people who used "Ctrl+I" can still use it for filtering.
It's true that remembering the last used mode in this tab when reopening the search bar can be unwanted, ...or maybe not. Its arguable.
Comment 3 Wladimir Palant 2017-02-06 19:30:37 UTC
Ah, so there is a global setting? Then my proposal is pointless of course :)

As to that backwards compat feature - it makes fairy little sense. People who prefer filtering can change the global setting and remap "Find in tab" to Ctrl+I so that they don't need to learn a new shortcut. A special Ctrl+I shortcut would only make sense if there were another shortcut to always open the search bar in search mode. But it's not worth touching this code just for that...