Bug 376007 - CTRL and outline selection dont work with add and substract to the selection
Summary: CTRL and outline selection dont work with add and substract to the selection
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Tools/Selection (show other bugs)
Version: 3.1.2
Platform: Ubuntu Linux
: NOR normal
Target Milestone: ---
Assignee: vanyossi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-04 15:57 UTC by z-uo
Modified: 2019-07-10 07:50 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description z-uo 2017-02-04 15:57:52 UTC
with the outline selection tool
and the add or substract action active
and the ctrl modifier to make staight lines (very useful by the way)
it doesn't add or substract the selection to the previous one but make a new one
unless you first release ctrl and then release the pen
Comment 1 Nicholas LaPointe 2017-02-05 04:18:33 UTC
Thanks for your report! I can reproduce this issue.
Comment 2 vanyossi 2019-07-09 19:54:48 UTC
Git commit 2aaa21f814268744a64ab7b6a9dbebbc29faa105 by Ivan Yossi.
Committed on 09/07/2019 at 19:54.
Pushed by ivany into branch 'master'.

Avoid resetting selection mode when pressing control in outline

This makes the polygon tool behave as the manual states, if a modifier is
pressed it will be retained even it is let go mid selection.

M  +2    -7    plugins/tools/selectiontools/kis_tool_select_outline.cc

https://invent.kde.org/kde/krita/commit/2aaa21f814268744a64ab7b6a9dbebbc29faa105
Comment 3 Halla Rempt 2019-07-10 07:50:03 UTC
Git commit bbdd9583898f15006395f5852ccc4711a1f7552d by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 10/07/2019 at 07:49.
Pushed by rempt into branch 'krita/4.2'.

Avoid resetting selection mode when pressing control in outline

This makes the polygon tool behave as the manual states, if a modifier is
pressed it will be retained even it is let go mid selection.

M  +2    -7    plugins/tools/selectiontools/kis_tool_select_outline.cc

https://invent.kde.org/kde/krita/commit/bbdd9583898f15006395f5852ccc4711a1f7552d