Bug 375965 - Move configure button out of the Save combo button
Summary: Move configure button out of the Save combo button
Status: RESOLVED FIXED
Alias: None
Product: Spectacle
Classification: Applications
Component: General (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Boudhayan Gupta
URL:
Keywords: usability
Depends on:
Blocks:
 
Reported: 2017-02-03 17:37 UTC by Nikolaos Kakouros
Modified: 2018-02-07 13:57 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 18.04


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolaos Kakouros 2017-02-03 17:37:47 UTC
It makes no sense to have it there. For a long time I thought the only preferences available were the 3 checkboxes exposed ("include mouse pointer", etc).
Comment 1 Boudhayan Gupta 2017-02-04 00:40:52 UTC
I'm not going to waste space by moving it out to its own button. Other ideas are welcome.
Comment 2 Nikolaos Kakouros 2017-02-05 20:19:12 UTC
Of course, you are free to do as you see fit. But be prepared to accept that your design will lack in user friendliness.
Comment 3 Simone Gaiarin 2017-10-10 13:17:58 UTC
The reason why it should be moved out is that those preferences are not only related to the save behaviour or the save button. Indeed there are preferences regarding the rectangular region behavior.

Only today after months of using this software I figured out I can remember the rectangular region mask, just because I never noticed that preference dialog, which is totally hidden.

There is enough space to put a 'gear' button somewhere, either in the buttons bar or in the main interface.
Comment 4 null 2018-01-31 18:44:17 UTC
Simone: I know you have an interest in usability. Hop over to https://phabricator.kde.org/T7841 in case you'd like to contribute good ideas or even patches. (And sorry I haven't got around to your "Open With" Diff yet, I did not forget!).
Comment 5 Nate Graham 2018-02-07 13:57:16 UTC
Git commit 04e292aaef385d857f6a485132a13f3c04a3b8c9 by Nathaniel Graham.
Committed on 07/02/2018 at 13:57.
Pushed by ngraham into branch 'master'.

(2/3) Move "Configure..." from save menu into its own button

Summary:
Part 2 of 3 for {T7841}
Depends on D10283
FIXED-IN: 18.04

Nobody can ever find Spectacle's Configure window because the menu item to invoke is hidden in the Save menu, oddly enough. Once {D10283} lands, there'll be room for another button. So, we move the "Configure..." item out of the Save menu and into its own button.

Test Plan:
Tested in KDE Neon:
- "Save" split button no longer has a "Preferences" item
- Button works and opens the Configure Spectacle dialog
- Button responds to standard ctrl+shift+, keyboard shortcut
- Button has standard "configure" icon

{F5695269}

Reviewers: #spectacle, alexeymin, rkflx

Reviewed By: #spectacle, alexeymin, rkflx

Subscribers: alexeymin, rkflx

Differential Revision: https://phabricator.kde.org/D10289

M  +9    -5    doc/index.docbook
M  +7    -4    src/Gui/KSMainWindow.cpp
M  +1    -0    src/Gui/KSMainWindow.h

https://commits.kde.org/spectacle/04e292aaef385d857f6a485132a13f3c04a3b8c9