Bug 375880 - Translation blocked
Summary: Translation blocked
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Application Launcher (Kickoff) (show other bugs)
Version: 5.8.95
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: David Edmundson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-02 01:04 UTC by Matthias
Modified: 2017-02-06 17:07 UTC (History)
7 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias 2017-02-02 01:04:28 UTC
See the categorys on the bottom:

http://funkyimg.com/i/2oaSG.png

tosky think, it may be related to these commit:

https://commits.kde.org/plasma-desktop/10842976eab5ef1c2c1d0196f04a6b0f45a8fcba
Comment 1 Luigi Toscano 2017-02-02 01:11:47 UTC
https://commits.kde.org/plasma-desktop/ea8374a149e592798e1f0cbdd667386c8d87b9af(In reply to Matthias from comment #0)
> See the categorys on the bottom:
> 
> http://funkyimg.com/i/2oaSG.png

Please add a written explanation of the image next time, and attach it (as an external image provider can disappear anytime).

To extend a bit:
Some words are not translated (like the labels of the main buttons, Favorites, Leave, etc) and apparently they are not extracted at all.

> 
> tosky think, it may be related to these commit:
> 

> https://commits.kde.org/plasma-desktop/
> 10842976eab5ef1c2c1d0196f04a6b0f45a8fcba
No, that commit is exactly the only one unrelated (it was mentioned in the discussion for another reason).

The commits that I think are relevant are:
https://commits.kde.org/plasma-desktop/ece1610945e382dbec2cd67495fd5bf7c8e0b764
https://commits.kde.org/plasma-desktop/ea8374a149e592798e1f0cbdd667386c8d87b9af
Comment 2 David Edmundson 2017-02-02 02:46:05 UTC
+                text: model.text ? i18n(model.text): ''

well that's never going to work.

Will fix for 5.9.1
Comment 3 David Edmundson 2017-02-06 17:07:58 UTC
Git commit f8a9c37373bb89543b4c323e55673718da1304db by David Edmundson.
Committed on 06/02/2017 at 17:07.
Pushed by davidedmundson into branch 'Plasma/5.9'.

Fix i18n extraction in Kickoff Buttons

Summary:
The current code returns a string containing an array of properties.
This breaks i18n extraction as i18n() inside another string won't work.

This patch returns properties as an object so that i18n translation
works.

The config is also changed so that extraction works properly.

Test Plan:
Kickoff loads as before
No i18n is nested in a string

Reviewers: apol, #plasma, broulik

Reviewed By: apol, #plasma, broulik

Subscribers: broulik, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4465

M  +6    -6    applets/kickoff/package/contents/ui/ConfigButtons.qml
M  +13   -6    applets/kickoff/package/contents/ui/FullRepresentation.qml

https://commits.kde.org/plasma-desktop/f8a9c37373bb89543b4c323e55673718da1304db