Bug 375871 - Drag functionality no longer working with minimized apps
Summary: Drag functionality no longer working with minimized apps
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 5.8.95
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-01 22:42 UTC by Elvis Angelaccio
Modified: 2017-02-08 15:42 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.9.2


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elvis Angelaccio 2017-02-01 22:42:59 UTC
This seems to be a regression in 5.9. Dragging items towards apps minimized in the task manager (e.g. Dolphin) no longer brings the app to the foreground, making impossible to drop the item.

Used to work in Plasma 5.8.
Comment 1 Kai Uwe Broulik 2017-02-02 11:44:34 UTC
It seems to be less reliable than it used to, ie. I sometimes have to wiggle the mouse around on the task item for the window to show up. Just entering the task item doesn't seem to start the raise timer. It still works overall, though.
Comment 2 Kai Uwe Broulik 2017-02-02 11:46:53 UTC
Looks like a regression caused by c50948648012e66b71b757e211432190d592c90d
Comment 3 David Edmundson 2017-02-02 12:43:40 UTC
Seems to works fine here: 
I have two Dolphin's drag from one into the other, and it brings the other into the foreground for dropping.

Can you explain exactly what you're dragging.
Comment 4 Elvis Angelaccio 2017-02-02 12:53:44 UTC
Right, now that I try again seems to work from Dolphin to Dolphin or from FV to Dolphin. Not sure what I did yesterday...

Can you try dragging a file from Ark to Dolphin? This definitely stopped working since 5.9
Comment 5 Elvis Angelaccio 2017-02-02 12:54:30 UTC
(In reply to Elvis Angelaccio from comment #4)
> Can you try dragging a file from Ark to Dolphin? This definitely stopped
> working since 5.9

(with Dolphin in the background)
Comment 6 Kai Uwe Broulik 2017-02-02 13:06:37 UTC
I can reproduce when dragging from Ark. It just rejects the drop and Task Manager moves out of the way to make room for dropping onto the panel.
Comment 7 Eike Hein 2017-02-07 11:45:27 UTC
This a regression from David's c50948648012e6 which made TM intentionally reject drags without an URL to avoid interfering with drop-on-containment.
Comment 8 Eike Hein 2017-02-07 12:04:40 UTC
Possible fix: https://phabricator.kde.org/D4475
Comment 9 David Edmundson 2017-02-08 15:42:20 UTC
Git commit 8709b7edd5d17d2369e8ca4d261ec186387fa20e by David Edmundson.
Committed on 08/02/2017 at 15:41.
Pushed by davidedmundson into branch 'Plasma/5.9'.

Reverse TaskManager DragDrop to blacklist Plasma instead of whitelisting URLs

Summary:
A previous patch made the task manager only accept drag events which
contained URL lists or internal taskmanager mimedata in order to make it
easier to drag applets onto the panel.

This broke a feature where you can drag arbitrary mimedata between
windows and hovering above a task will raise that window.

This patch reverses the logic to only ignore plasmoids, and accept all
other drag/drops.
FIXED-IN: 5.9.2

Test Plan:
Dragged applet from Widget explorer onto task manager and the task
manager moved to
the side to allow a drop.

set sorting to manual and moved a task

Dragged some text onto a task, and that window raised immediately

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D4476

M  +5    -10   applets/taskmanager/package/contents/ui/MouseHandler.qml

https://commits.kde.org/plasma-desktop/8709b7edd5d17d2369e8ca4d261ec186387fa20e