Bug 375865 - Quick fill: select/enter item does not lock payee
Summary: Quick fill: select/enter item does not lock payee
Status: RESOLVED FIXED
Alias: None
Product: skrooge
Classification: Applications
Component: general (other bugs)
Version First Reported In: 2.7.0
Platform: Kubuntu Linux
: NOR normal
Target Milestone: 25.1.0
Assignee: Stephane MANKOWSKI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-01 20:29 UTC by vicnet
Modified: 2020-10-08 18:57 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description vicnet 2017-02-01 20:29:24 UTC
1) In edit panel, go to payee edit field
1bis) eventually, global clear field btn
2) enter one letter
  => no lock symbol, but a clear (x) arrow
3) click on clear arrow (2 times, one to close listbox, one to erase)
  => no lock symbol, no clear arrow
4) tab to go in type field
  =>  lock symbol on empty payee field !

I expect to have a lock field symbol eventually when I enter something (few letter), but it should display when leaving the field or more even, when select one payee on list.

Moreover, if there are multiple payees that start with the same name, like "Intermarche" and "Intermarche Dac", sometime it retrieves one or the other even if I enter and select the shorter one.
Comment 1 Stephane MANKOWSKI 2017-02-08 21:55:09 UTC
Git commit ea1f7206297c94580a26506bba61e1c36c05be86 by Stephane Mankowski.
Committed on 08/02/2017 at 21:54.
Pushed by smankowski into branch 'master'.

Quick fill: select/enter item does not lock payee

M  +1    -0    CHANGELOG
M  +1    -1    plugins/skrooge/skrooge_operation/skgoperationplugin.cpp
M  +4    -25   plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp
M  +0    -1    plugins/skrooge/skrooge_operation/skgoperationpluginwidget.h

https://commits.kde.org/skrooge/ea1f7206297c94580a26506bba61e1c36c05be86
Comment 2 vicnet 2017-09-01 03:43:57 UTC
Test in 2.8.1 problem is exactly the same:
1) in edit tab, clear all fields
2) in payee, enter few letter and select a payee (by key or click)
=> payee is not lock (no light blue background color)
3) leave the field with tab
=> no lock
4) go back on payee and use magic filler
=> magic use payee to find older: OK
=> if a longer payee name starts with the entered payee it is replaced 
example: 'carrefour' => 'carrefour dac'

Remarks: Combo fields could be locked with double-click, and the it seems OK
but double-click should not be mandatory...
Comment 3 vicnet 2017-09-01 03:45:23 UTC
Same after migrate to 2.9.0
Comment 4 Stephane MANKOWSKI 2017-09-02 11:12:56 UTC
Git commit d3a2a5cbe1c452b75079fe86c2f5c243dd87caee by Stephane Mankowski.
Committed on 02/09/2017 at 11:12.
Pushed by smankowski into branch 'master'.

Quick fill: select/enter item does not lock payee

M  +1    -0    CHANGELOG
M  +6    -0    plugins/skrooge/skrooge_operation/skgoperationpluginwidget.cpp

https://commits.kde.org/skrooge/d3a2a5cbe1c452b75079fe86c2f5c243dd87caee
Comment 5 Stephane MANKOWSKI 2017-09-02 11:17:18 UTC
Hi Vicnet,

I did the expected modification but this will change the behavior.
Indeed, before this modification, I was able to do that:
1- Enter "Alim" in payee field
2- Type F10 (to trigger fast edit)

Result before:
All fields were set with the values returned by "fast edit"

Result now:
All fields are set with the values returned by "fast edit" except the field where the "fast edit" is applied (still at the entered value)

I have a doubt: is the new behavior better than the previous one?

What is your point of view?
Comment 6 vicnet 2017-09-04 19:53:18 UTC
OK, I understand the usage you have of the magic filling.
I think this way of using F12 is valid, just border line because for me, magic filling, is used to fill other fields.
To fill current field, especially in a combo field, there is a short select list...
But you are the boss :-)

I remark also that combo field is not blue after selecting an item in short list.
Sometime, after fews selection, it become blue but the first time not...
After became blue, It generally work (ie become blue) after reset, like it should do... Don't understand why it is ok or not.
Comment 7 Stephane MANKOWSKI 2017-09-05 07:14:51 UTC
(In reply to vicnet from comment #6)
> OK, I understand the usage you have of the magic filling.
> I think this way of using F12 is valid, just border line because for me,
> magic filling, is used to fill other fields.
> To fill current field, especially in a combo field, there is a short select
> list...
> But you are the boss :-)
I will let it like this (as you want).
> 
> I remark also that combo field is not blue after selecting an item in short
> list.
> Sometime, after fews selection, it become blue but the first time not...
> After became blue, It generally work (ie become blue) after reset, like it
> should do... Don't understand why it is ok or not.
If fact, this is simple: the widget becomes blue (locked) when the focus is lost (tab key pressed or click on another widget) and the field is not empty. So, this is normal that the combobox is not locked after the selection of a value.
Comment 8 vicnet 2020-10-08 18:57:49 UTC
In 2.20, there is still this pb.
Go to nex field with Tab, even if it lost the focus, does not lock the field.

# clear all field
# enter few char
# click on a payee
# enter Tab
=> no lock