Bug 375862 - Menubar button does not work with Aurorae
Summary: Menubar button does not work with Aurorae
Status: RESOLVED FIXED
Alias: None
Product: kwin
Classification: Plasma
Component: aurorae (show other bugs)
Version: 5.9.0
Platform: Other Linux
: NOR major
Target Milestone: ---
Assignee: KWin default assignee
URL:
Keywords:
: 377270 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-02-01 19:35 UTC by Mircea Kitsune
Modified: 2017-03-22 15:52 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.9.5
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mircea Kitsune 2017-02-01 19:35:11 UTC
Plasma 5.9.0 reintroduces the ability to change your menu bar into a button or a Plasma widget. Unfortunately the title bar button does not work with Aurorae themes. If this option is chosen, and the menu button is configured under the KWin button settings, the normal menu bar disappears but no button is shown on the title bar in its place. To reproduce:

1. Go to: Configure Desktop - Appearance - Application Style - Widget Style - Fine Tuning. Set "Menubar style" to "Title bar button".

2. Also go to: Configure Desktop - Appearance - Application Style - Widget Style - Window Decorations - Buttons. Make sure you have the menu button somewhere on your title bar (the icon with 3 dashes).

3. Open any native KDE application, such as Dolphin or KWrite or KCalc.

Result: The normal menu bar is gone, but there is no button on the title bar. The button should show where it was configured, as seen in the official screenshot: https://www.kde.org/announcements/plasma-5.9/global-menus-window-bar.png

Additional: Could this be due to the themes not having a button (svg element) for this feature? As I'm not aware what the name of the new svg file must be, I am currently unable to test this. I remember that in KDE4, the application icon would be used in this circumstance. Themes I have tested with:

Colorbit: https://www.opendesktop.org/p/1002614/
Freeze: https://www.opendesktop.org/p/1002663/
Comment 1 Martin Flöser 2017-02-01 20:35:37 UTC
> Could this be due to the themes not having a button (svg element) for this feature?

Yes, quite likely. Though in KDE 4 times I think we just used the icon button again.
Comment 2 Martin Flöser 2017-03-22 15:45:43 UTC
*** Bug 377270 has been marked as a duplicate of this bug. ***
Comment 3 Kai Uwe Broulik 2017-03-22 15:52:03 UTC
Git commit ffbb25497c3f71c05652617f51e34a1c0a2bbb03 by Kai Uwe Broulik.
Committed on 22/03/2017 at 15:49.
Pushed by broulik into branch 'Plasma/5.9'.

[Aurorae DecorationButton] Hook up app menu button

This makes clicking the application menu button trigger the menu.

CHANGELOG: Aurorae window decorations now support global menu button
FIXED-IN: 5.9.5

Differential Revision: https://phabricator.kde.org/D5130

M  +2    -1    plugins/kdecorations/aurorae/src/qml/DecorationButton.qml

https://commits.kde.org/kwin/ffbb25497c3f71c05652617f51e34a1c0a2bbb03
Comment 4 Kai Uwe Broulik 2017-03-22 15:52:03 UTC
Git commit 3e0ddba683ca68cb50b403cb3893fa2fc9d2d737 by Kai Uwe Broulik.
Committed on 22/03/2017 at 15:50.
Pushed by broulik into branch 'Plasma/5.9'.

[Plastik Decoration] Show application menu button if client has one

CHANGELOG: Plastik window decoration now supports global menu

Differential Revision: https://phabricator.kde.org/D5131

M  +1    -2    plugins/kdecorations/aurorae/themes/plastik/package/contents/ui/PlastikButton.qml

https://commits.kde.org/kwin/3e0ddba683ca68cb50b403cb3893fa2fc9d2d737