Bug 375798 - Pressing Esc on the finder widget closes current tab (Hex Viewer and Lister mode)
Summary: Pressing Esc on the finder widget closes current tab (Hex Viewer and Lister m...
Status: RESOLVED WORKSFORME
Alias: None
Product: krusader
Classification: Applications
Component: krviewer (other bugs)
Version First Reported In: 2.4.0-beta3 "Single Step"
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-31 14:21 UTC by Wladimir Palant
Modified: 2018-05-06 00:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Wladimir Palant 2017-01-31 14:21:59 UTC 
I am using Krusader 2.4.0-beta3 on Ubuntu 16.04.

Steps to reproduce:

1. Select a file in Krusader and press F3 to view it.
2. Press Ctrl+Shift+H (Hex Viewer mode) or Ctrl+Shift+L (Lister mode).
3. Press Ctrl+F to open text search.
4. Reconsider - press Esc to close search again.

Expected results:

Search closes, the tab stays open however unless you press Esc again. That's the behavior in Text Viewer or Generic Viewer mode.

Actual results:

Search closes but the current tab is closed as well.
Comment 1 Wladimir Palant 2017-01-31 15:20:36 UTC 
I can see that at least for the Lister mode this issue has been resolve in 2.5.0 (see https://phabricator.kde.org/D2436). Hex Viewer is an entirely different code path, so the issue probably persists there.
Comment 2 Wladimir Palant 2017-01-31 15:37:16 UTC 
Never mind, I figured out that Hex Viewer is implemented by the same lister code - so https://phabricator.kde.org/D2436 should have addressed it as well. So I assume that this should be resolved as WORKSFORME if somebody can verify (I cannot, 2.5.0 isn't currently available for Ubuntu).
Comment 3 Wladimir Palant 2017-01-31 18:54:22 UTC 
Actually, I verified by compiling 2.5.0 from source - both for Hex Viewer and Lister mode.