Bug 375793 - Folder view should honor kiorc settings
Summary: Folder view should honor kiorc settings
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Folder (show other bugs)
Version: 5.8.95
Platform: Other Linux
: NOR major
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-31 12:20 UTC by Elvis Angelaccio
Modified: 2017-01-31 14:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.8.6


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Elvis Angelaccio 2017-01-31 12:20:49 UTC
From the discussion in https://www.reddit.com/r/linux/comments/5r6va0/how_to_easily_trick_file_manager_users_to_execute/

It is currently possible to run executable scripts from Folder View by clicking them, even though ~/.config/kiorc says:

[Executable scripts]
behaviourOnLaunch=alwaysAsk

Instead FV should have asked me if I really wanted to run the executable script, like Dolphin does.

Note: ~/.config/kiorc is currently edited only by Dolphin, even though is supposed to contains global settings. There was some discussions with VDG to move the settings from DolphinSettings->General->Confirmation to a proper KCM. See Thomas comment in https://git.reviewboard.kde.org/r/129383/
Comment 1 Kai Uwe Broulik 2017-01-31 14:00:44 UTC
Patch https://phabricator.kde.org/D4367
Comment 2 Kai Uwe Broulik 2017-01-31 14:08:17 UTC
Git commit 771e57f3b2c19f4e6f867c01c2457ec87531b4cf by Kai Uwe Broulik.
Committed on 31/01/2017 at 14:08.
Pushed by broulik into branch 'Plasma/5.8'.

[Folder View] show script execution prompt when clicking item

When clicking a file in FolderView, we should ask for whether to open or run a script depending on user settings.
This is what Dolphin does.
FIXED-IN: 5.8.6

Differential Revision: https://phabricator.kde.org/D4367

M  +2    -1    containments/desktop/plugins/folder/foldermodel.cpp

https://commits.kde.org/plasma-desktop/771e57f3b2c19f4e6f867c01c2457ec87531b4cf
Comment 3 Kai Uwe Broulik 2017-01-31 14:55:42 UTC
Git commit bb1d73a99f0cfddae6befb4e14312ebb9c9fe30e by Kai Uwe Broulik.
Committed on 31/01/2017 at 14:55.
Pushed by broulik into branch 'Plasma/5.9'.

[Folder View] Open selection in preferred application instead of running them

This makes it consistent with Dolphin which will run scripts only if one is selected.
If multiple are selected, they are opened in their preferred associated application (e.g. Kate) instead.

I also removed the restriction on opening folders when only one item is selected.

Differential Revision: https://phabricator.kde.org/D4368

M  +11   -3    containments/desktop/plugins/folder/foldermodel.cpp

https://commits.kde.org/plasma-desktop/bb1d73a99f0cfddae6befb4e14312ebb9c9fe30e