Bug 375725 - Kate inadequately proposes to reload deleted file at exit
Summary: Kate inadequately proposes to reload deleted file at exit
Status: RESOLVED FIXED
Alias: None
Product: kate
Classification: Applications
Component: general (show other bugs)
Version: 16.08
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: KWrite Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-29 19:57 UTC by opensuse.lietuviu.kalba
Modified: 2019-03-04 18:53 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
WEBM video (1.02 MB, video/webm)
2017-01-29 19:57 UTC, opensuse.lietuviu.kalba
Details

Note You need to log in before you can comment on or make changes to this bug.
Description opensuse.lietuviu.kalba 2017-01-29 19:57:18 UTC
Created attachment 103707 [details]
WEBM video

I open several files simultaneously in Kate.
I remove non-active file.
I close Kate. 
One of options is funny: to reload deleted file.
Reloading this context is meaningless, because program will exit regardless of existence of file:
- even if I undo delete of file, after pressing Reload, Kate immediately exit;
- if I don't undelete file – Kate also immediately exit.

You should remove button "Reload" for this context.
Comment 1 Christoph Cullmann 2019-03-04 18:53:13 UTC
Git commit 0c15edfbd44fc8b094769b546546ff7a9484cdf2 by Christoph Cullmann, on behalf of loh tar.
Committed on 04/03/2019 at 18:54.
Pushed by cullmann into branch 'master'.

[RFC] Defuse KateMainWindow::showModOnDiskPrompt

Summary:
Related: bug 351443

Test Plan:
Fixed in a way as suggested in bug report.

  Expected Results:
  Exit without asking (file was not edited since last time in kate, so there is no info to lose)

This dialog is for me pretty confusing and annoying.
- In which case may that question (without this patch) useful?
- Why should I reload a file when I like to close Kate?
- Click "Ignore" you will asked again, where you can overwrite the file on disk. The opposite from your first intend.
- Click "Diff" keeps the dialog the focus with the result that you can't scroll in the loaded diff. With dark theme is it hard to read too
- You can end in some "endless" dialog boxes

So, how about to remove that dialog?
{F6643583}

Reviewers: #kate, cullmann

Reviewed By: #kate, cullmann

Subscribers: cullmann, ngraham, kwrite-devel, #kate

Tags: #kate

Differential Revision: https://phabricator.kde.org/D19397

M  +2    -1    kate/katemainwindow.cpp

https://commits.kde.org/kate/0c15edfbd44fc8b094769b546546ff7a9484cdf2
Comment 2 Christoph Cullmann 2019-03-04 18:53:13 UTC
Git commit 0c15edfbd44fc8b094769b546546ff7a9484cdf2 by Christoph Cullmann, on behalf of loh tar.
Committed on 04/03/2019 at 18:54.
Pushed by cullmann into branch 'master'.

[RFC] Defuse KateMainWindow::showModOnDiskPrompt

Summary:
Related: bug 351443

Test Plan:
Fixed in a way as suggested in bug report.

  Expected Results:
  Exit without asking (file was not edited since last time in kate, so there is no info to lose)

This dialog is for me pretty confusing and annoying.
- In which case may that question (without this patch) useful?
- Why should I reload a file when I like to close Kate?
- Click "Ignore" you will asked again, where you can overwrite the file on disk. The opposite from your first intend.
- Click "Diff" keeps the dialog the focus with the result that you can't scroll in the loaded diff. With dark theme is it hard to read too
- You can end in some "endless" dialog boxes

So, how about to remove that dialog?
{F6643583}

Reviewers: #kate, cullmann

Reviewed By: #kate, cullmann

Subscribers: cullmann, ngraham, kwrite-devel, #kate

Tags: #kate

Differential Revision: https://phabricator.kde.org/D19397

M  +2    -1    kate/katemainwindow.cpp

https://commits.kde.org/kate/0c15edfbd44fc8b094769b546546ff7a9484cdf2