Bug 375639 - Quick search only let type one vocal with accent mark at first place
Summary: Quick search only let type one vocal with accent mark at first place
Status: RESOLVED FIXED
Alias: None
Product: krusader
Classification: Applications
Component: general (show other bugs)
Version: 2.5.0
Platform: openSUSE Linux
: NOR normal
Target Milestone: ---
Assignee: Krusader Bugs Distribution List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-28 04:55 UTC by Rafael Linux User
Modified: 2018-05-06 00:16 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
attachment-16939-0.html (2.43 KB, text/html)
2017-02-01 00:30 UTC, Rafael Linux User
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Linux User 2017-01-28 04:55:53 UTC
In Spanish, file names can have vowels with accent mark, like "áéíóú" or "ÁÉÍÓÚ". To obtain this accented vowels, user must type the "accent" (') key and then the wovel. On quick search mode (typing any character to search quickly on the active panel), Krusader let me type any of those characters in the very first place, but no one more. That's to say I can type: "á" but not "áá" or "aá". So, if I try to search "atmósfera" krusader will try to look "atmsfera". 

I wish you understood my explanation.

Thank you
Comment 1 Alex Bikadorov 2017-01-29 14:34:05 UTC
I can confirm it too and will work on it. But a good solution is complicated
Comment 2 Rafael Linux User 2017-01-29 18:13:17 UTC
Well, I will try to simplify a possible fix. "Quick search" functionality doesn't distinguish between uppercase and lowercase letters. Accent mark is a pronunciation difference so, for Quick Search, it should let introduce "á" (or not let do it) but in any case must show any "a", "A", "á" or "Á". The principal problem nowadays is that "Quick search" only show files that match exactly the vocal typed.

"Quick search" should work like Dolphin "search" function.

I wish this could simplify to find a solution.

Thank you
Comment 3 Alex Bikadorov 2017-01-29 18:44:47 UTC
>"Quick search" should work like Dolphin "search" function.

It doesn't work for me in Dolphin: a directory called "test_á" is not found with the search string "test_a". Not with filter bar or with "Find"


But back to the actual problem: the list view is focused and not the search field line you're typing in. This is for seeing the current item for navigating inside the file view.

But filtering key events is tricky now. Writing a letter with accent is not a QKeyPressEvent but a QInputMethodEvent.
I would be better to focus the correct widget and find a way to always show current item marker.

Oh, and a quick workaround: before you want to type the accent, click into the search field with the mouse to focus it. It will work this way.
Comment 4 Rafael Linux User 2017-02-01 00:30:27 UTC
Created attachment 103742 [details]
attachment-16939-0.html

I tried with Dolphin new searches and results are inconsistent!!!! I need
to test more before tell something more, but in Dolphin case I guess is
related with NFS mounted folders.

Your workaround works (good trick) but need to "click" on each accented
vowel, doing he experiencie not so "Quick".

Thank you anyway

El dom., 29 ene. 2017 a las 19:44, Alex Bikadorov (<bugzilla_noreply@kde.org>)
escribió:

> https://bugs.kde.org/show_bug.cgi?id=375639
>
> --- Comment #3 from Alex Bikadorov <alex.bikadorov@kdemail.net> ---
>
> >"Quick search" should work like Dolphin "search" function.
>
> It doesn't work for me in Dolphin: a directory called "test_á" is not found
> with the search string "test_a". Not with filter bar or with "Find"
>
>
> But back to the actual problem: the list view is focused and not the search
> field line you're typing in. This is for seeing the current item for
> navigating
> inside the file view.
>
> But filtering key events is tricky now. Writing a letter with accent is
> not a
> QKeyPressEvent but a QInputMethodEvent.
> I would be better to focus the correct widget and find a way to always show
> current item marker.
>
> Oh, and a quick workaround: before you want to type the accent, click into
> the
> search field with the mouse to focus it. It will work this way.
>
> --
> You are receiving this mail because:
> You are on the CC list for the bug.
> You reported the bug.
Comment 5 Alex Bikadorov 2017-02-15 17:17:48 UTC
Git commit 210ca94555bd8d6213f11a605456c8895da34fe3 by Alexander Bikadorov.
Committed on 14/02/2017 at 15:52.
Pushed by abikadorov into branch 'master'.

Panel: don't switch focus to panel view when typing in search bar

FIXED: [ 375639 ] Allow typing special characters (e.g. with accent or acute) in search bar

M  +21   -26   krusader/Panel/krsearchbar.cpp

https://commits.kde.org/krusader/210ca94555bd8d6213f11a605456c8895da34fe3