Bug 375633 - Two buttons in Map tab on the Right Sidebar are not working
Summary: Two buttons in Map tab on the Right Sidebar are not working
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Geolocation-Workflow (show other bugs)
Version: 5.5.0
Platform: Appimage Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-27 23:34 UTC by Barbara Scheffner
Modified: 2017-10-29 20:14 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.8.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Barbara Scheffner 2017-01-27 23:34:02 UTC
The buttons "Lock the map position" and "See more information on the Internet" are doing nothing. The first one has no icon on it at all, the second one shows a locked folder icon that doesn't represent the function. Should be some kind of Internet icon. The "Map settings" button shows the same icon, should be something that indicates "map" or at least "settings" (not as good).
Comment 1 Barbara Scheffner 2017-01-28 00:04:19 UTC
After increasing the icon size I realized that these "locked folders" are actually showing something like a little globe. Well, o.k., but don't we have something better than that? Why a folder symbol at all? And the globe on it so tiny that you need the eyes of a hawk? Why not the applications-internet icon? Or there is also a globe icon under "Actions". And there would be also map-flat and map-globe which would be an alternative for the "Map settings" button. The last three are b&w, so would fit better to the other buttons.
Comment 2 Maik Qualmann 2017-01-28 22:05:42 UTC
Git commit 3916e74b52f57054dbb535bf972e0346410b5c0a by Maik Qualmann.
Committed on 28/01/2017 at 22:03.
Pushed by mqualmann into branch 'master'.

fix icons from the locked map button

M  +6    -2    utilities/geolocation/geoiface/mapwidget.cpp

https://commits.kde.org/digikam/3916e74b52f57054dbb535bf972e0346410b5c0a
Comment 3 Maik Qualmann 2017-01-28 22:14:25 UTC
Both buttons work here as expected. The button for locked map locks the map view for another position when a different image is selected with a different map position. The other button opens the default web browser and opens the map from the selected service. The problem with the globe icon is known and can be fixed with a new version of Breeze Icons (Bug 374313).

Maik
Comment 4 caulier.gilles 2017-01-29 09:57:32 UTC
Maik,

I think it still a problem with icon set packaged as ressource Qt::rcc. Look report from Simon here :

https://bugs.kde.org/show_bug.cgi?id=374313

Gilles
Comment 5 Maik Qualmann 2017-01-30 06:59:54 UTC
Gilles,

Qt can not open a browser URL in the Appimage:

digikam.general: "http://maps.google.com/?q=53.89458,11.2837833333&spn=0.05,0.05&t=h&om=1"
This application failed to start because it could not find or load the Qt platform plugin "xcb" in "".

Reinstalling the application may fix this problem.
/usr/bin/xdg-open: line 595:  2976 Aborted (core dumped) kde-open${KDE_SESSION_VERSION} "$1"
Comment 6 caulier.gilles 2017-01-30 07:51:04 UTC
Well here under Mageia5.1, it work fine.

Try Help/Handbook. It use QDesktopService to open default web-browser.

Gilles
Comment 7 caulier.gilles 2017-01-30 07:54:38 UTC
Maik,

The AppImage sheell script is inspired from Krita one.

About XCB support, Look comments here :

https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/appimage/04-build-appimage.sh#n170

and here :

https://cgit.kde.org/digikam-software-compilation.git/tree/project/bundles/appimage/04-build-appimage.sh#n180

Gilles
Comment 8 Maik Qualmann 2017-01-30 11:22:47 UTC
Yes, the same with Help/Handbook. Here under openSUSE Tumbleweed. As I said only the Appimage has the problem. I will take a look in the scripts.

Maik
Comment 9 Barbara Scheffner 2017-01-30 13:09:19 UTC
Help/Handbook also doesn't work here under Kubuntu.
Comment 10 caulier.gilles 2017-01-30 14:10:06 UTC
Wolfgang,

Looking in QDesktopService source code from Qt, the way to open a web browser (in case to open handbook for ex), is done through this method :

https://github.com/openwebos/qt/blob/master/src/gui/util/qdesktopservices_x11.cpp#L95

typically, the code search 2 environment variable set with your account :

DEFAULT_BROWSER
BROWSER

On my computer this is set like this : declare -x BROWSER="/bin/www-browser"

which open firefox.

Please open a console and run 'export' on command line. this will return all environment variable with your account. Look if one of both value is defined.

Gilles Caulier
Comment 11 Barbara Scheffner 2017-01-30 22:56:16 UTC
Gilles,

export showed none of these two. declare -p neither. I did

wolfgang@wolfgang-tuxedo:~$ declare -x BROWSER="/usr/bin/firefox"
wolfgang@wolfgang-tuxedo:~$ export

and got

declare -x BROWSER="/usr/bin/firefox"

but this didn't help. /usr/bin/firefox is a link pointing to /usr/lib/firefox.sh which is wrong. I found firefox.sh in /usr/lib/firefox and did

declare -x BROWSER="/usr/lib/firefox/firefox.sh"

but to no avail. Help/Handbook is still not working and the buttons in Right Sidebar/Maps neither.
Comment 12 caulier.gilles 2017-02-01 09:16:59 UTC
Git commit 8b19ee7daf20c1e8c28d433bec6d013986e108f4 by Gilles Caulier.
Committed on 01/02/2017 at 09:12.
Pushed by cgilles into branch 'master'.

fix wrong path in AppImage run bash script to handle Qt5 plugins.
This must fix the XCB integration error when an url request is passed to QDesktopService.
Related: bug 375808

M  +1    -1    project/bundles/appimage/data/AppRun

https://commits.kde.org/digikam-software-compilation/8b19ee7daf20c1e8c28d433bec6d013986e108f4
Comment 13 caulier.gilles 2017-02-01 18:47:18 UTC
New version of digiKam 5.5.0 pre-release AppImage bundle will be uploaded in few minites to GDrive. Please give me a feedback to see if XCB problem is fixed.

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Gilles Caulier
Comment 14 Barbara Scheffner 2017-02-01 19:19:58 UTC
I'm not sure what the "XCB problem" is (couldn't follow all the tech talk) but the lock map button works now. The one below not and Help/Handbook neither.
Comment 15 Maik Qualmann 2017-02-01 20:06:07 UTC
The same here, QDesktopService::openUrl() from AppImage does not work here under openSUSE.

Maik
Comment 16 caulier.gilles 2017-02-01 21:33:18 UTC
Maik, there is always the XCB problem on the console ?

Typically, Qt search the plattform xcb plugin for X11 (do not ask me why...)

The path set in internal bash script from AppImage set the PATH adjustments to find all Qt plugins. This path was wrong in fact. I'm sure that it's was a problem.

So, there is another one to solve this issue. Which one, i don't know yet...

Gilles
Comment 17 caulier.gilles 2017-04-15 10:51:32 UTC
Git commit b1a447ae996373a083c4b186c15bf177864a0de5 by Gilles Caulier.
Committed on 15/04/2017 at 10:48.
Pushed by cgilles into branch 'master'.

fix typo in sheel script to start appImaghe bundle. The env var is not set properly and make dysfunction at run time with system based libraries.
Related: bug 375808

M  +3    -3    project/bundles/appimage/data/AppRun

https://commits.kde.org/digikam-software-compilation/b1a447ae996373a083c4b186c15bf177864a0de5
Comment 18 Maik Qualmann 2017-10-29 20:14:15 UTC
This bug is no longer reproducible in the current version, not even in the AppImage. I close this bug.

Maik