Bug 375376 - Dark theme in Android app
Summary: Dark theme in Android app
Status: RESOLVED FIXED
Alias: None
Product: kdeconnect
Classification: Applications
Component: android-application (show other bugs)
Version: unspecified
Platform: Android Android 4.x
: NOR wishlist
Target Milestone: ---
Assignee: Albert Vaca Cintora
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-21 15:15 UTC by Dragoon Aethis
Modified: 2018-04-23 16:36 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Remote Control view (27.73 KB, image/png)
2017-01-21 15:15 UTC, Dragoon Aethis
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dragoon Aethis 2017-01-21 15:15:06 UTC
Created attachment 103572 [details]
Remote Control view

Aside from being *preeeettttyyyy*, dark theme has one very nice property: It dramatically lowers power usage on phones with AMOLED screens. For longer sessions with remote control (using the phone as a touchpad), phone's screen must be on all the time, and that pulls a lot of juice constantly. AMOLED screens completely disable black sections of the screen, significantly improving battery life. This also avoids burn-in on such screens. (The attached screenshot is the primary place where a dark theme would be greatly appreciated, preferably with most UI elements hidden, if easily possible.)
Comment 1 Nicolas Fella 2018-04-23 16:36:17 UTC
Git commit a1f1693d0bf0b138b538ee5951fe16480ea317a0 by Nicolas Fella, on behalf of Philip Cohn-Cort.
Committed on 23/04/2018 at 16:35.
Pushed by nicolasfella into branch 'master'.

Add a dark theme

Summary:

This revision adds dark mode support to the app ( T7044 ). It does so by injecting
theme information into each activity, and making sure that all Views
define their colors by reference to theme attributes.

In order to make this work, all of the buttons with images (like the list
of available devices) now are tinted according to the theme.

While all versions of android support the theme, only devices running
Android ICS or higher will have a toggle button in the drawer.

Test Plan: Open all the screens, both with and without the dark theme on.

Reviewers: #kde_connect, mtijink, #vdg, nicolasfella

Reviewed By: #kde_connect, mtijink, nicolasfella

Subscribers: apol, ngraham, nicolasfella, mtijink

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D11694

A  +5    -0    res/drawable/state_list_drawer_background_dark.xml
A  +18   -0    res/layout-v14/nav_dark_mode_switch.xml
M  +41   -22   res/layout/activity_device.xml
M  +1    -6    res/layout/activity_main.xml
M  +5    -2    res/layout/list_item_with_icon_entry.xml
M  +2    -1    res/layout/mpris_control.xml
M  +5    -2    res/layout/preference_with_button.xml
A  +12   -0    res/values-v21/styles-dark.xml
A  +6    -0    res/values/attrs.xml
A  +40   -0    res/values/styles-dark.xml
M  +14   -0    res/values/styles.xml
M  +2    -0    src/org/kde/kdeconnect/Plugins/FindMyPhonePlugin/FindMyPhoneActivity.java
M  +2    -0    src/org/kde/kdeconnect/Plugins/MousePadPlugin/MousePadActivity.java
M  +2    -0    src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisActivity.java
M  +2    -0    src/org/kde/kdeconnect/Plugins/NotificationsPlugin/NotificationFilterActivity.java
M  +2    -0    src/org/kde/kdeconnect/Plugins/RunCommandPlugin/RunCommandActivity.java
M  +2    -0    src/org/kde/kdeconnect/Plugins/SharePlugin/SendFileActivity.java
M  +4    -0    src/org/kde/kdeconnect/Plugins/SharePlugin/ShareActivity.java
M  +2    -0    src/org/kde/kdeconnect/UserInterface/AppCompatPreferenceActivity.java
M  +1    -0    src/org/kde/kdeconnect/UserInterface/CustomDevicesActivity.java
M  +1    -0    src/org/kde/kdeconnect/UserInterface/DeviceFragment.java
M  +44   -0    src/org/kde/kdeconnect/UserInterface/MainActivity.java
A  +46   -0    src/org/kde/kdeconnect/UserInterface/ThemeUtil.java

https://commits.kde.org/kdeconnect-android/a1f1693d0bf0b138b538ee5951fe16480ea317a0