Bug 375349 - Plasmoid can't be set to declared minimumWidth
Summary: Plasmoid can't be set to declared minimumWidth
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop Containment (show other bugs)
Version: 5.8.95
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Sebastian Kügler
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2017-01-20 20:51 UTC by Konstantin Shtepa
Modified: 2018-10-11 14:44 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Shtepa 2017-01-20 20:51:34 UTC
Plasmoid can't be set to declared minimumWidth due to error on calculation of appletItem minimumWidth and due to error in resize handler.
Comment 1 Konstantin Shtepa 2017-01-20 20:52:33 UTC
Already made a corresponding patch, would upload it tomorrow.
Comment 2 Konstantin Shtepa 2017-01-22 11:34:21 UTC
Patched with https://phabricator.kde.org/D4204
Comment 3 David Edmundson 2017-01-22 20:53:56 UTC
> Plasmoid can't be set to declared minimumWidth due to error on calculation of appletItem minimumWidth and due to error in resize handler.

I believe you, but can you explain what the error actually is (here or on phabricator with your patch)
Otherwise I have to redo all the investigation you just did..

I'm assuming it's this change?
 var minimumWidth = appletItem.minimumWidth + appletHandle.width;
Comment 4 Konstantin Shtepa 2017-01-24 10:56:29 UTC
Explained it all in patch in Phabricator.
Copy:
This bug was because of mess in size relationship. Because of it plasmoid wouldn't get smaller than Layout.minimumWidth + 2 * handleWidth. Bug was in appletItem minimumWidth(where in appletContainer.margins.right was included first excess handleWidth) calculation and in AppletHandler.qml resize calculation(resizeHandle.onPositionChanged where in calculation of var minimumWidth was included second excess handleWidth).
Comment 5 Nate Graham 2017-12-14 22:53:47 UTC
The patch was accepted and merged; can this be marked as RESOLVED?
Comment 6 Andrew Crouthamel 2018-09-28 02:24:50 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 7 Nate Graham 2018-10-11 14:44:07 UTC
Patch was merged, this should have been closed.