Bug 375169 - kajongg uses hardcoded path kde4 and deprecated kde4-config
Summary: kajongg uses hardcoded path kde4 and deprecated kde4-config
Status: RESOLVED FIXED
Alias: None
Product: kajongg
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Wolfgang Rohdewald
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-17 07:49 UTC by Burkhard Lück
Modified: 2017-01-21 00:10 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Burkhard Lück 2017-01-17 07:49:06 UTC
kajongg recent master build from sources

$ wcgrep kde4 .
./setup.py:57:    kdeDirs[type] = os.popen("kde4-config --expandvars --install %s" % type).read().strip()
./kajongg:2:exec /usr/share/kde4/apps/kajongg/kajongg.py $*
grep: ./doc/.index.docbook.kate-swp: Permission denied
./doc/index.docbook:669:                        Predefined voices for every language. They live in a folder like <filename class="directory">/usr/share/kde4/apps/kajongg/voices/LANG</filename> where
./doc/index.docbook:1036:       <listitem><para>the python bindings for KDE4 (python-kde4)</para></listitem>
./kajonggserver:2:exec /usr/share/kde4/apps/kajongg/kajonggserver.py $*
./kajonggserver3:2:exec /usr/share/kde4/apps/kajongg/kajonggserver3.py $*
./src/kde.py:50:                '~/.kde4/share/apps/kajongg/kajonggserver.db')
./src/log.py:183:            # when using pykde4, this is already translated at this point
./src/winprep.py:64:    "kde4-config --expandvars --install data".split()).strip()
./src/winprep.py:66:    "kde4-config --expandvars --install icon".split()).strip()
./src/winprep.py:80:targetDir = DEST + '/kde4/apps/kmahjongglib'
./src/winprep.py:81:os.makedirs(DEST + '/kde4/apps')
./src/winprep.py:87:os.makedirs(DEST + '/kde4/apps/kajongg')
./src/winprep.py:88:copytree(dataDir + '/kajongg/voices', DEST + '/kde4/apps/kajongg/voices')
./src/winprep.py:119:move('oggdec.exe', DEST + '/kde4/apps/kajongg/voices')
./src/winprep.py:121:copy('backgroundselector.ui', DEST + '/kde4/apps/kajongg')
./src/winprep.py:122:copy('tilesetselector.ui', DEST + '/kde4/apps/kajongg')
./src/winprep.py:135:# http://l10n.kde.org/stats/gui/trunk-kde4/po/kajongg.po/
./src/winprep.py:147:    for kde45 in ('l10n-kde4', 'l10n-kf5'):
./src/winprep.py:157:                        kde45, lang, filename).split(), stderr=DEVNULL)
./src/winprep.py:158:                print('found:', lang, kde45, filename)
./src/kdestub.py:262:                     '%s/share/kde4/apps/LICENSES/GPL_V2' % KStandardDirs.prefix):
./src/kdestub.py:756:                'data': ['share/kde4/apps', 'share'],
./src/kdestub.py:762:                    ['share/kde4/apps/kajongg',
./src/kdestub.py:774:                kde4configPath = self.which('kde4-config')
./src/kdestub.py:775:                if kde4configPath:
./src/kdestub.py:777:                        kde4configPath.split(b'/')[1].decode('utf-8'))
./src/kdestub.py:779:                    raise Exception('Cannot find kde4-config')
./src/kdestub.py:1530:            versions = subprocess.Popen(['kde4-config', '-v'],

No kde4 in my build log:
wcgrep kde4 log/kdegames_kajongg-20170117.log -> no hit