Bug 375103 - Icons in Panel not shown if Desktop file is in ~/Desktop
Summary: Icons in Panel not shown if Desktop file is in ~/Desktop
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Icon widget (show other bugs)
Version: 5.8.95
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-15 18:28 UTC by Fabian Maurer
Modified: 2017-01-26 09:14 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.9.0
Sentry Crash Report:


Attachments
Desktop file on the Desktop (3.36 KB, image/png)
2017-01-15 18:28 UTC, Fabian Maurer
Details
Desktop file in a folder on the desktop (3.63 KB, image/png)
2017-01-15 18:29 UTC, Fabian Maurer
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Maurer 2017-01-15 18:28:29 UTC
Created attachment 103427 [details]
Desktop file on the Desktop

I'm using folder view as desktop, and title says it. I have a .desktop file for Skype:
If it's on the Desktop and I move it into the panel, it's icon is missing.
If it's in a folder the Desktop and I move it into the panel, it's icon is shown.
Comment 1 Fabian Maurer 2017-01-15 18:29:14 UTC
Created attachment 103428 [details]
Desktop file in a folder on the desktop

Note that it used to work, even if the file was on the desktop.
Comment 2 Kai Uwe Broulik 2017-01-15 22:57:23 UTC
Probably because I evaluate desktop files only if it's a local path but desktop:/ isn't file:/ so it just generates a link to the .desktop file rather than the application it points to.
Comment 3 Kai Uwe Broulik 2017-01-16 12:50:23 UTC
Patch https://phabricator.kde.org/D4157
Comment 4 Kai Uwe Broulik 2017-01-26 09:14:00 UTC
Git commit 83719920b2c811b4f5c9279994b76a072ceaa521 by Kai Uwe Broulik.
Committed on 26/01/2017 at 09:07.
Pushed by broulik into branch 'Plasma/5.9'.

[Icon Applet] Use KIO::statJob to work with remote URLs

Files in desktop:/ are local files but QUrl doesn't know this.
Also allows us to determin mime type and icon for files on a network share.
While at it, improve default naming logic.
FIXED-IN: 5.9.0

Differential Revision: https://phabricator.kde.org/D4157

M  +99   -66   applets/icon/iconapplet.cpp
M  +1    -0    applets/icon/package/contents/ui/main.qml

https://commits.kde.org/plasma-workspace/83719920b2c811b4f5c9279994b76a072ceaa521