Bug 375051 - New scroll bar width: cofiguration missing and inconsistent with GTK theme
Summary: New scroll bar width: cofiguration missing and inconsistent with GTK theme
Status: RESOLVED FIXED
Alias: None
Product: Breeze
Classification: Plasma
Component: gtk theme (show other bugs)
Version: 5.8.95
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: scionicspectre
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-14 18:01 UTC by Christian (Fuchs)
Modified: 2017-08-02 12:48 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.11.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2017-01-14 18:01:51 UTC
In 5.8.95 a new default scrollbar width is set. 
This brings two issues: 

1) According to the commit, it should be configurable as an enum, with three sizes. This configuration seems to be missing

2) The breeze GTK  (same version) still seems to use the old width, so now scrollbars look inconsistent between GTK and Qt applications
Comment 1 Hugo Pereira Da Costa 2017-01-18 10:55:52 UTC
Hi,
thanks for reporting.

Despite of what the commit says (sorry we did not update), and after long discussions on phabricator (https://phabricator.kde.org/D3210), it was decided not to make the scrollbar visible width configurable. 
The rationale is that
- we avoid the added code complexity
- the default small width is good
- the hit area is unchanged with respect to the previous design (it is larger than the visible width of the handle), so that no usability is lost.

Now, that this makes the scrollbar inconsistent with gtk should be fixed of course.
Reassigning to the gtk theme (of which I am not the maintainer and for which I lack the skills to fix)

Best,

Hugo
Comment 2 Christian (Fuchs) 2017-01-18 12:32:54 UTC
(In reply to Hugo Pereira Da Costa from comment #1)
> Hi,

Hi! 

> thanks for reporting.

You're welcome.

> Despite of what the commit says (sorry we did not update), and after long
> discussions on phabricator (https://phabricator.kde.org/D3210), it was
> decided not to make the scrollbar visible width configurable. 
> The rationale is that
> - we avoid the added code complexity

understandable.

> - the default small width is good

Heavily disagree, but that's a matter of personal preference, so not really discussable

> - the hit area is unchanged with respect to the previous design (it is
> larger than the visible width of the handle), so that no usability is lost.

actually making it larger than visible is a massive usability issue. If you disabled animations and thus it is always visible, grabbing the mouse event when near but not on the scrollbar is against user expectations and thus a big UX flaw.  Say I have a file view in dolphin and I want to start selecting multiple items by drawing a rectangle. If I started close to a scrollbar, it might activate the scrolling instead, even though the mouse was not over it. 
That would be very bad.



> Now, that this makes the scrollbar inconsistent with gtk should be fixed of
> course.
> Reassigning to the gtk theme (of which I am not the maintainer and for which
> I lack the skills to fix)

I shall patch both to the old width locally, then. 

> Best,
> 
> Hugo

Kind regards, 

Christian
Comment 3 Felix Miata 2017-04-27 22:14:19 UTC
(In reply to Hugo Pereira Da Costa from comment #1)
> - the default small width is good

Where can people find the discussion that reached this reduced usability/accessibility conclusion and implementation?
Comment 4 Hugo Pereira Da Costa 2017-04-28 06:22:28 UTC
(In reply to Felix Miata from comment #3)
> (In reply to Hugo Pereira Da Costa from comment #1)
> > - the default small width is good
> 
> Where can people find the discussion that reached this reduced
> usability/accessibility conclusion and implementation?

See comment #1
Click the phabricator link
Comment 5 Artem Grinev 2017-06-25 06:08:27 UTC
I spent a couple of mornings to adjust scrollbars so they fit the Qt theme. I made changes to the assets+gtkrc and also changed the "Scrollbars" section in gtk-3.20/gtk.css. The only one issue I found is that Firefox doesn't respect GTK3 css scrollbar:hover selector so hovering over the scrollbar doesn't show scrollbar trough.
Is there any way to contribute this changes to the project?
Comment 6 Christoph Feck 2017-06-26 12:48:30 UTC
Use https://phabricator.kde.org/differential/diff/create/ and set Repository to 'Breeze for Gtk'. Then please add the link for the Diff here.
Comment 8 Christoph Feck 2017-07-12 11:44:06 UTC
You did not complete the steps. Click "Continue" and fill out the details.
Comment 9 Artem Grinev 2017-07-13 16:51:48 UTC
https://phabricator.kde.org/D6688

Ok, is it right now?
Comment 10 Christoph Feck 2017-07-26 17:37:31 UTC
Artem, did your changes solve all issues mentioned in this ticket?

See https://commits.kde.org/breeze-gtk/01a86601804222929441c0c1c8bb0db6d4ee2769
Comment 11 Artem Grinev 2017-07-28 01:46:45 UTC
New scrollbars lack support of Breeze-dark and have some bugs for now but otherwise I think this issue is solved.