Bug 374986 - 'Shift' resize-gesture on canvas : no preview of diameter while resizing
Summary: 'Shift' resize-gesture on canvas : no preview of diameter while resizing
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 3.1 Beta
Platform: Compiled Sources Linux
: NOR grave
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-13 04:27 UTC by David REVOY
Modified: 2017-01-18 07:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2017-01-13 04:27:38 UTC
Hi,

Something new after updating krita/3.1~git (over the last 24h): holding 'Shift' key over the canvas plus a drag of stylus to perform a gesture to resize the brush size doesn't display an interactive preview of the diameter anymore. It is reproducible with the classic outline or rounded outline.

Note: the brush outline now blinks also a lot (subtle blink, at a high frame rate) while drawing. Making krita/3.1~git difficult to use for long painting test. That's why I flag this bug as 'grave'. Definitely a release blocker.

(Display: OpenGL canvas, Nvidia proprietary driver, XFCE desktop, Qt 5.7.1-1, Manjaro.)
Comment 1 wolthera 2017-01-13 14:25:36 UTC
If it happened in the last 24 hours, it can only be this one:

https://phabricator.kde.org/R37:ebfaab84a240efe7b9ba42e65ecdd346e0737007
or this one:
https://phabricator.kde.org/R37:d5e2991cacd21f5b3258615013ea7f1372ce4af1

The later is so minimal it is probably the gradient tool fix.
Comment 2 David REVOY 2017-01-18 04:23:19 UTC
Thank you @Wolthera,
I went to my source folder, and applied:
git revert ebfaab84a240efe7b9ba42e65ecdd346e0737007
then I added a description for a commit in local, and built again.
It does fix the bug, now I'm able to resize brush with Shift again. 

This is the commit I reverted: https://cgit.kde.org/krita.git/commit/?h=krita/3.1&id=ebfaab84a240efe7b9ba42e65ecdd346e0737007
Comment 3 Halla Rempt 2017-01-18 07:20:09 UTC
Okay... I think that we should just revert that fix in the 3.1 branch then, and postpone the 3.1.2 release a bit until Dmitry is back from his vacation and can work on the proper fix.
Comment 4 Halla Rempt 2017-01-18 07:21:02 UTC
Git commit d574e8ba1df9f03d951f15bbb8aa08451eeedbd0 by Boudewijn Rempt.
Committed on 18/01/2017 at 07:20.
Pushed by rempt into branch 'krita/3.1'.

Revert "Temporary workaround for color picker bug in the gradient tool"

This reverts commit ebfaab84a240efe7b9ba42e65ecdd346e0737007.

This change broke shift-click resizing of brushes.

M  +1    -11   libs/ui/tool/kis_tool_paint.cc

https://commits.kde.org/krita/d574e8ba1df9f03d951f15bbb8aa08451eeedbd0