Bug 374964 - Pinning apps non-effective
Summary: Pinning apps non-effective
Status: RESOLVED WORKSFORME
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager (show other bugs)
Version: 5.8.95
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-12 15:56 UTC by Hrvoje Senjan
Modified: 2017-01-16 08:42 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
KMail's xprop (57.01 KB, text/plain)
2017-01-12 22:02 UTC, Hrvoje Senjan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Hrvoje Senjan 2017-01-12 15:56:10 UTC
This is a substitute for 'show launcher when not running'? If so, trying to pin an app is not working. If no, then that action is missing from context menu =)

Pin -> selecting any option -> app is not in the launcher section. What about 'old-school' launchers? They also offer to be pinned but they already are...
Comment 1 Eike Hein 2017-01-12 16:07:13 UTC
It's just a label change, the code is the same.
Comment 2 Hrvoje Senjan 2017-01-12 16:08:32 UTC
So i see from git log. Still (un)pinning isn't working whatever the name
Comment 3 Hrvoje Senjan 2017-01-12 16:09:33 UTC
(i thought it's a code change as now there is only option to bind app to activity)
Comment 4 Eike Hein 2017-01-12 16:15:29 UTC
Works fine for me. Please provide more information, e.g. the app it's not working for and the xprop output for its window.
Comment 5 Hrvoje Senjan 2017-01-12 22:02:40 UTC
Created attachment 103380 [details]
KMail's xprop

From limited testing, none of the apps i tried are pinned. Here's an xprop for a kmail window.
Comment 6 Eike Hein 2017-01-13 07:54:28 UTC
KMail is a bad testcase because it's known to be semi-broken (the name of its .desktop file doesn't match its WM_CLASS, so we hit a fallback codepath that makes pinning less good - though it's still supposed to work). The KMail team has been informed of this months ago but isn't fixing it for some reason.

Anyway, things work fine here and there are no other reports so ... I'm afraid you'll have to try and investigate what happens on your end. Could you watch for interesting terminal output or so?
Comment 7 Hrvoje Senjan 2017-01-13 09:32:55 UTC
Problem for me that also e.g. libreoffice or konqueror or gwenview or totem or ... are not working. More to that, unpinning is not available as action for already existing launchers...
Comment 8 Eike Hein 2017-01-13 09:38:19 UTC
"Unpin" shows fine here. Something is definitely broken on your system.
Comment 9 Hrvoje Senjan 2017-01-14 11:22:12 UTC
After rebuilding all of frameworks & kde/workspace, things started working... maybe there was a temp breakage somewhere...
Comment 10 Eike Hein 2017-01-16 08:42:46 UTC
Good that it's working again, thanks for reporting back.