Bug 374865 - Remove "Tree View" option in settings when built without khtml
Summary: Remove "Tree View" option in settings when built without khtml
Status: RESOLVED FIXED
Alias: None
Product: systemsettings
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-10 12:25 UTC by Elias Probst
Modified: 2018-07-20 12:52 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.12.7
Sentry Crash Report:


Attachments
Screenshot showing "View Style" settings (120.06 KB, image/png)
2017-01-10 12:26 UTC, Elias Probst
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2017-01-10 12:25:58 UTC
The "Tree View" option is gone from SystemSettings' configuration dialog, only "Icon View" can be selected.

If this was intentional, the "View Style" selection should be removed, as a radio button selection with just a single choice doesn't make sense.

If it wasn't intentional, "Tree View" should be restored as choice for "View Style".

See also attached screenshot.

Running systemsettings from git 4ec9d0a83a2af and Qt 5.7.1.
Comment 1 Elias Probst 2017-01-10 12:26:42 UTC
Created attachment 103325 [details]
Screenshot showing "View Style" settings
Comment 2 Christoph Feck 2017-01-10 16:19:20 UTC
Did you compile it yourself? If not, please ask your packager if they compiled it against KHML dependency.
Comment 3 Elias Probst 2017-01-10 17:55:44 UTC
(In reply to Christoph Feck from comment #2)
> Did you compile it yourself? If not, please ask your packager if they
> compiled it against KHML dependency.

Good point - the Gentoo ebuild for kde-plasma/systemsettings provides the "classic" USE flag which pulls in the KF5::KHtml dependency when enabled.

So the point I made in my initial comment would be instead:

When only one "View Style" option is available, don't show the "View Style" selection at all, as selecting from a single choice doesn't make any sense from a UX perspective.
Comment 4 Kai Uwe Broulik 2018-07-20 12:52:49 UTC
Git commit 86f0f92caf0f28fdce3df9e30fc22a67738f92ea by Kai Uwe Broulik.
Committed on 20/07/2018 at 12:34.
Pushed by broulik into branch 'Plasma/5.12'.

Hide view selection if there is only one plugin to choose
FIXED-IN: 5.12.7

Differential Revision: https://phabricator.kde.org/D14247

M  +1    -0    app/SettingsBase.cpp

https://commits.kde.org/systemsettings/86f0f92caf0f28fdce3df9e30fc22a67738f92ea