Bug 374815 - Binding Loop for "portrait" plasma/components/TabButton.qml
Summary: Binding Loop for "portrait" plasma/components/TabButton.qml
Status: RESOLVED FIXED
Alias: None
Product: libplasma
Classification: Frameworks and Libraries
Component: components (other bugs)
Version First Reported In: 5.29.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Marco Martin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-09 15:10 UTC by Christian (Fuchs)
Modified: 2017-01-09 15:31 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/plasma-framework/12a4709b6c51f879528a47783835955daa135415
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Christian (Fuchs) 2017-01-09 15:10:38 UTC 
The above mentioned variable in the mentioned file causes a binding loop warning whenever I create a tab with no label on purpose: 

e.g. 

 PlasmaComponents.TabBar {
            id: groupTabBar
            
            anchors {
                top: parent.top
                left: parent.left
                right: parent.right
            }
            
            PlasmaComponents.TabButton {
                id: groupLightsTab
                iconSource: "im-jabber"
            }
            
            PlasmaComponents.TabButton {
                id: groupWhitesTab
                iconSource: "color-picker-white"
            }
}

will create two warnings each 

file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/plasma/components/TabButton.qml:120:5: QML QtObject: Binding loop detected for property "portrait"
Comment 1 Marco Martin 2017-01-09 15:31:51 UTC 
Git commit 12a4709b6c51f879528a47783835955daa135415 by Marco Martin.
Committed on 09/01/2017 at 15:29.
Pushed by mart into branch 'master'.

portait prop is not relevant when there is no text

this fixes a binding loop on this property
when there is no label
Change-Id: I71616a6c86cd4acdaff47f141ed5c676358db496

M  +1    -1    src/declarativeimports/plasmacomponents/qml/TabButton.qml

https://commits.kde.org/plasma-framework/12a4709b6c51f879528a47783835955daa135415