Bug 374551 - [wish] a brush 'outliner' rendering less noisy
Summary: [wish] a brush 'outliner' rendering less noisy
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: Usability (show other bugs)
Version: 3.1.1
Platform: Other Linux
: NOR wishlist
Target Milestone: ---
Assignee: Dmitry Kazakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-04 15:48 UTC by David REVOY
Modified: 2020-02-24 12:55 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
[gif animation of the noisy outliner] (76.36 KB, image/gif)
2017-01-04 15:48 UTC, David REVOY
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David REVOY 2017-01-04 15:48:20 UTC
Created attachment 103194 [details]
[gif animation of the noisy outliner]

Hi, 

Today I launched Mypaint to test an old brush; and I found something really calm about the way Mypaint display the outliner/cursor while painting ; for sure, it's less featured than the one of Krita ( only circles, limited size, no rotation, no angle, no bitmap brush-mask preview ) but it doesn't produce "visual noises" or change shape when moving hover the canvas.
On Krita ; the outliner (even using a rounded brush and flying over a white background) keeps changing aspect ; pixels dances, it's a bit noisy. ( in attachement a gifanimation demo. I'm using the 'Outliner' + 'Small circle' cursor to show the center of my brush. 

This is a wish open to the creativity of a developer to improve this rendering :-)
Comment 1 Halla Rempt 2017-01-09 13:14:21 UTC
Erm, I confirmed this, but isn't the circle outline already more or less what you want?
Comment 2 David REVOY 2017-01-09 15:28:35 UTC
@Boud: True, the circle outline is already more or less what I want. It looks perfect in term of rendering. Thank you for pointing it. It would be perfect if there was a possibility to mix this type of rendering with a preview of the shape of the classic "outline".
Comment 4 Dmitry Kazakov 2020-02-13 11:19:12 UTC
Git commit 4d921768b94ffaf7c8bc3558982bdabd691c784d by Dmitry Kazakov.
Committed on 07/02/2020 at 09:11.
Pushed by dkazakov into branch 'master'.

Fix strobbing of the brush outline becasue of subpixel precision

The patch basically aligns the center of the outline to the pixel
grid of the widget.

M  +8    -0    libs/ui/tool/kis_tool.cc
M  +2    -0    libs/ui/tool/kis_tool.h
M  +1    -3    libs/ui/tool/kis_tool_freehand.cc
M  +2    -2    libs/ui/tool/kis_tool_paint.cc

https://invent.kde.org/kde/krita/commit/4d921768b94ffaf7c8bc3558982bdabd691c784d
Comment 5 Dmitry Kazakov 2020-02-24 12:55:30 UTC
Git commit 13fc73ada62ab1d986d729b12b6b96327b512124 by Dmitry Kazakov.
Committed on 24/02/2020 at 11:06.
Pushed by dkazakov into branch 'krita/4.2'.

Fix strobbing of the brush outline becasue of subpixel precision

The patch basically aligns the center of the outline to the pixel
grid of the widget.

M  +8    -0    libs/ui/tool/kis_tool.cc
M  +2    -0    libs/ui/tool/kis_tool.h
M  +1    -3    libs/ui/tool/kis_tool_freehand.cc
M  +2    -2    libs/ui/tool/kis_tool_paint.cc

https://invent.kde.org/kde/krita/commit/13fc73ada62ab1d986d729b12b6b96327b512124