Bug 374450 - DATA LOSS: Saving a file can overwrite other file
Summary: DATA LOSS: Saving a file can overwrite other file
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Showfoto-Save (show other bugs)
Version: 5.3.0
Platform: Arch Linux Linux
: NOR major
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-02 07:47 UTC by Simon Persson
Modified: 2022-02-04 22:35 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 5.5.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Persson 2017-01-02 07:47:20 UTC
Steps to reproduce:
1. Open folder with photos using the "open folder" button.
2. Select a photo to edit by double-clicking on it in the thumbbar.
3. Make some edit to the photo.
4. Select another photo in the thumbbar, single click only.
5. Click "Save".

The problem is that the modified photo is now written to the filename of the current selection in the thumbbar, overwriting the contents of that file. I assume this is not the intended function, at least I found it very unexpected. This happened to me several times, each time I noticed the data loss I restored the overwritten photo from backup and continued editing other photos. Then it happened again, and again. Took me a long time to understand what was going on.
Comment 1 Maik Qualmann 2017-01-02 11:41:27 UTC
This problem has been fixed some time ago. I can not reproduce it.

Please check with current universal AppImage Linux bundle available here :

https://drive.google.com/drive/folders/0BzeiVr-byqt5Y0tIRWVWelRJenM

Maik
Comment 2 Simon Persson 2017-01-19 04:46:42 UTC
I have now upgraded my installation to version 5.4.0 and the behaviour has not changed, still a problem.
Comment 3 Maik Qualmann 2017-01-19 07:13:43 UTC
Gilles,

can you reproduce this problem?

Simon,

is displayed the correct filename for saving in the dialog?

Maik
Comment 4 caulier.gilles 2017-01-19 08:02:40 UTC
Maik,

It's not reproducible here. Right file name is printed in messagebox.

Note that versionning feature is disabled in this case to check this file. Enabling versionning give another messagebox. As a new file is created the problem do not exist in ths case.

Gilles
Comment 5 caulier.gilles 2017-01-19 08:06:13 UTC
Maik,

I want to report more details : When message box appear, a confirmation appear after to press Save button. This confirmation dialog ask if i'm sure to overwrite the file. The file name printed is the right one also. If i confirm, the right file is overwritten.

digiKam 5.5.0 from git/master

Gilles
Comment 6 caulier.gilles 2017-01-19 08:09:31 UTC
Maik,

I confirm this bug now.

Look well the report : it's about Showfoto, not DK image editor. The behavior is completely different. Dysfunction is quickly reproducible. When switching from on icon thumbnail to another one, no messagebox is displayed.

Gilles
Comment 7 Maik Qualmann 2017-01-19 11:28:18 UTC
Yes, I know it's about showFoto. But a message box is only displayed if the image was also changed and choose a different image in the thumbbar. It is not reproducible here, even when changing the image with the keys. Can someone create a screencast?

Maik
Comment 8 caulier.gilles 2017-01-19 13:49:52 UTC
Maik,

Screencast of the dysfucntion :

https://drive.google.com/open?id=0BzeiVr-byqt5ZTF2czRRRmhjQ28

Gilles
Comment 9 Maik Qualmann 2017-01-19 21:01:40 UTC
It almost looks as if the correct image is not loaded. The error message when trying to save the RAW is correct. But why not a messagebox??? Here's my screencast:

https://drive.google.com/file/d/0ByXDEhL2xmagOHhfVmZIMjFBaGc/view

Maik
Comment 10 caulier.gilles 2017-01-19 22:00:30 UTC
Maik,

Create a new fresh account and start Showfoto. It's reproducible ?

Gilles
Comment 11 Maik Qualmann 2017-02-10 22:27:51 UTC
Git commit adef76d645d9ec1bac093fe4cf46e151eeff8572 by Maik Qualmann.
Committed on 10/02/2017 at 22:26.
Pushed by mqualmann into branch 'master'.

this must fix the possible wrong save url
FIXED-IN: 5.5.0

M  +2    -1    NEWS
M  +4    -7    showfoto/main/showfoto.cpp

https://commits.kde.org/digikam/adef76d645d9ec1bac093fe4cf46e151eeff8572