Bug 374415 - umbrello/KF5 does not show the KF5 crash dialog
Summary: umbrello/KF5 does not show the KF5 crash dialog
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: frameworks5
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks: 373932 374811
  Show dependency tree / graph
 
Reported: 2017-01-01 11:44 UTC by Ralf Habacker
Modified: 2017-05-27 11:29 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/umbrello/badcf99a56f2e2d06b0ac64f98b6f1b0624b0cc9
Version Fixed In: 2.22.2 (KDE Applications 17.04.2)

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ralf Habacker 2017-01-01 11:44:37 UTC 
Umbrello/KDE4 shows the KDE provided crash dialog in case of any fatal application error like segfault or similar.

On KF5 builds the crash dialog is not displayed (see unittest testcrashhandler).
Comment 1 Ralf Habacker 2017-01-01 11:47:17 UTC 
Git commit 6761c2b02c0001a5f4deaec849dcd25979a5667f by Ralf Habacker.
Committed on 01/01/2017 at 11:46.
Pushed by habacker into branch 'Applications/16.12'.

Add unit test for crash handler.

M  +3    -0    unittests/CMakeLists.txt
A  +45   -0    unittests/testcrashhandler.cpp     [License: GPL (v2/3)]

https://commits.kde.org/umbrello/6761c2b02c0001a5f4deaec849dcd25979a5667f
Comment 2 Christoph Feck 2017-05-26 23:18:00 UTC 
You need to use KCrash::initialize()

The move from KApplication to QApplication lost automatic initialization.

See for example commit in KCharSelect application: https://cgit.kde.org/kcharselect.git/commit/?id=a874c8fb362d84d5e7f44309aeacd2539d45b736
Comment 3 Ralf Habacker 2017-05-27 11:29:18 UTC 
Git commit badcf99a56f2e2d06b0ac64f98b6f1b0624b0cc9 by Ralf Habacker.
Committed on 27/05/2017 at 11:28.
Pushed by habacker into branch 'Applications/17.04'.

Fix 'umbrello/KF5 does not show the KF5 crash dialog'.

Thanks to Christoph Feck for pointing out how to fix.
FIXED-IN: 2.22.2 (KDE Applications 17.04.2)

M  +1    -0    CMakeLists.txt
M  +5    -1    umbrello/CMakeLists.txt
M  +2    -0    umbrello/main.cpp

https://commits.kde.org/umbrello/badcf99a56f2e2d06b0ac64f98b6f1b0624b0cc9