Bug 374383 - Selection mask names are saved as "KisSelectionMask"
Summary: Selection mask names are saved as "KisSelectionMask"
Status: RESOLVED FIXED
Alias: None
Product: krita
Classification: Applications
Component: File formats (show other bugs)
Version: 3.1.1
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
: 374439 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-12-31 08:59 UTC by Nicholas LaPointe
Modified: 2017-01-02 10:23 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Nicholas LaPointe 2016-12-31 08:59:56 UTC
Reproducible: Always

Selection mask names are set to "KisSelectionMask" after a save/load roundtrip.

Steps to Reproduce:
1. Create a new document
2. Add a local selection
3. Save, close, and reopen document

The selection is now named "KisSelectionMask"
Comment 1 Nicholas LaPointe 2016-12-31 11:34:47 UTC
Ah, I think I found the problem (although I'm not sure what to change to have it be correct).
The copy constructor for KisSelectionMask sets the name to that.

Additionally, I think there might be another issue with the constructor. Saving the document or duplicating a layer with a selection mask produces the following output on the terminal:
"QObject::connect: Cannot connect (null)::timeout() to KisSelectionMask::slotSelectionChangedCompressed()"
Comment 2 peat 2017-01-01 22:05:59 UTC
*** Bug 374439 has been marked as a duplicate of this bug. ***
Comment 3 peat 2017-01-01 22:07:21 UTC
I marked this as confirmed as I can reproduce this
Comment 4 Halla Rempt 2017-01-02 10:21:24 UTC
Git commit 46da9991345a15776cf6004e03690b3684fc15b7 by Boudewijn Rempt.
Committed on 02/01/2017 at 10:21.
Pushed by rempt into branch 'master'.

Don't set the name to a fixed string in the copy constructor

M  +1    -1    libs/image/kis_selection_mask.cpp

https://commits.kde.org/krita/46da9991345a15776cf6004e03690b3684fc15b7
Comment 5 Halla Rempt 2017-01-02 10:23:22 UTC
Git commit 1d920dbac6ddcd3d78e97dff587cfe5ac8ad1ee4 by Boudewijn Rempt.
Committed on 02/01/2017 at 10:22.
Pushed by rempt into branch 'master'.

M  +3    -2    libs/image/kis_selection_mask.cpp

https://commits.kde.org/krita/1d920dbac6ddcd3d78e97dff587cfe5ac8ad1ee4
Comment 6 Halla Rempt 2017-01-02 10:23:34 UTC
Git commit dda1d521aa202e622561889d36bfea32f53cabb8 by Boudewijn Rempt.
Committed on 02/01/2017 at 10:23.
Pushed by rempt into branch 'krita/3.1'.

Don't set the name to a fixed string in the copy constructor

M  +1    -1    libs/image/kis_selection_mask.cpp

https://commits.kde.org/krita/dda1d521aa202e622561889d36bfea32f53cabb8
Comment 7 Halla Rempt 2017-01-02 10:23:34 UTC
Git commit ab1f1a4379f9352853461e1c7403351cc6c40e19 by Boudewijn Rempt.
Committed on 02/01/2017 at 10:23.
Pushed by rempt into branch 'krita/3.1'.

M  +3    -2    libs/image/kis_selection_mask.cpp

https://commits.kde.org/krita/ab1f1a4379f9352853461e1c7403351cc6c40e19