Bug 374300 - All UI elements should respect active color theme
Summary: All UI elements should respect active color theme
Status: RESOLVED INTENTIONAL
Alias: None
Product: kscreenlocker
Classification: Plasma
Component: breeze-theme (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR wishlist
Target Milestone: ---
Assignee: Plasma Development Mailing List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-29 19:19 UTC by Alex
Modified: 2018-07-20 11:14 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alex 2016-12-29 19:19:16 UTC
When choosing a dark background color for the lock screen, the black font is hard to read. There should just be an option to choose the font color (and possibly the font).

The same applies for sddm as well, at least for the breeze-design with custom background image.
Comment 1 Jens Reuterberg 2016-12-30 11:10:07 UTC
Currently the only option is to change the wallpaper you use (either by modding it to include lighter sections in the area where the dark text is or changing it entirely). 

The issue isn't that there is anything blocking a way to set it from a design perspective but rather where to include it currently and how hard it is to do from a technical standpoint.

We have a massive problem with settings - and there has been quite the discussion about SDDM/Lockscreen/Wallpaper-settings which will probably affect this. Adding it in the "set wallpaper" section for Lockscreen and SDDM seems like a good temporary solution (since they are mostly empty space currently) but then again what will happen with the work when those are redesigned? 

TL;DR from a design perspective nothing blocks the idea that you can change font colour - at the same time, the programmers will have to reply on how complex it is to add - and whether the risk of a future overhaul will make that effort worthless.
Comment 2 Alex 2016-12-30 11:16:55 UTC
An easy colorchooser next to the wallpaper-chooser (or even color chooser in case of the lockscreen) would be a good start. Stuff like font type may be better off in full themes (didn't try to use other sddm themes, yet).
Another option may be choosing a dark/light color based on the average color of the wallpaper, but i see several possiblities for this to fail.
Comment 3 Rog131 2017-05-03 14:31:40 UTC
Dublicate / same kind of as Bug 369676 - White lockscreen text's readability depends on background - https://bugs.kde.org/show_bug.cgi?id=369676
Comment 4 Alex 2018-07-18 18:56:52 UTC
The readability issue is gone with Bug 369676.
I am not sure if the bug should stay open for the possiblity to configure colors for better theming.
Comment 5 Nate Graham 2018-07-19 21:08:04 UTC
Certain elements on the lock screen respect the active color theme--such as the Unlock button and the textfield. I think it would make the most sense to continue in this vein and make them ALL respect the theme, rather than adding an additional UI to change the color of only some of the elements on the lock screen.
Comment 6 Rog131 2018-07-20 05:25:02 UTC
(In reply to Nate Graham from comment #5)
> Certain elements on the lock screen respect the active color theme--such as
> the Unlock button and the textfield. I think it would make the most sense to
> continue in this vein and make them ALL respect the theme, rather than
> adding an additional UI to change the color of only some of the elements on
> the lock screen.

By my knowledge:

Text is using complementary normal text color.
Password field is using view normal background color.
Password text is using view normal text color.
Unlock button is using button normal background color.
Unlock text is using button normal text color.

Earlier: https://forum.kde.org/viewtopic.php?f=14&t=151172
Comment 7 David Edmundson 2018-07-20 11:14:22 UTC
They do all respect the theme.

The only difference is they're in the colour group "Complementary"