Bug 374275 - Unit converter does not suggest local currency
Summary: Unit converter does not suggest local currency
Status: RESOLVED FIXED
Alias: None
Product: krunner
Classification: Plasma
Component: converter (show other bugs)
Version: 5.8.5
Platform: Arch Linux Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-29 06:48 UTC by Kishore Gopalakrishnan
Modified: 2017-02-16 21:17 UTC (History)
2 users (show)

See Also:
Latest Commit: https://commits.kde.org/kdeplasma-addons/8fea513310f285414d91123c23a808cae7994cb8
Version Fixed In: 5.9.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Kishore Gopalakrishnan 2016-12-29 06:48:53 UTC 
When you try to convert a currency, the currency converter should also suggest conversion to the local currency. Right now, it suggests EUR, GBP, CAD and JPY if I type '1 USD'. However, in System Settings, I have chosen my region as 'India'. I would expect one of the suggested conversions to be the local currency (INR).
Comment 1 Kai Uwe Broulik 2016-12-30 13:20:42 UTC 
Good idea
Comment 2 Kai Uwe Broulik 2016-12-30 13:35:29 UTC 
Patch: https://phabricator.kde.org/D3870
Comment 3 Kai Uwe Broulik 2016-12-30 21:08:52 UTC 
Git commit 8fea513310f285414d91123c23a808cae7994cb8 by Kai Uwe Broulik.
Committed on 30/12/2016 at 21:08.
Pushed by broulik into branch 'master'.

[Converter Runner] Also convert to the user's local currency

The "most common units" for currency listed by KUnitConversion are EUR, USD, GBP, CAD, JPY
but the local currency is probably what the user cares most about.
FIXED-IN: 5.9.0

Differential Revision: https://phabricator.kde.org/D3870

M  +10   -0    runners/converter/converterrunner.cpp

https://commits.kde.org/kdeplasma-addons/8fea513310f285414d91123c23a808cae7994cb8
Comment 4 Víctor 2017-02-16 20:55:30 UTC 
Does not works for me. Appear the same ones: EUR, GBP, CAD and JPY. Some especial indication?
Comment 5 Kai Uwe Broulik 2017-02-16 21:06:11 UTC 
What is your local currency? What locale are you using? (eg. knowing your $LANG, $LANGUAGE, $LC_ALL, $LC_MONETARY would be useful)
Comment 6 Víctor 2017-02-16 21:11:09 UTC 
(In reply to Kai Uwe Broulik from comment #5)
> What is your local currency? What locale are you using? (eg. knowing your
> $LANG, $LANGUAGE, $LC_ALL, $LC_MONETARY would be useful)

In Regional Settings I have enabled all the items pointing to my country. Is there a file or another setting in the system? 
 
Thanks.
Comment 7 Víctor 2017-02-16 21:14:25 UTC 
(In reply to Víctor from comment #6)
> (In reply to Kai Uwe Broulik from comment #5)
> > What is your local currency? What locale are you using? (eg. knowing your
> > $LANG, $LANGUAGE, $LC_ALL, $LC_MONETARY would be useful)
> 
> In Regional Settings I have enabled all the items pointing to my country. Is
> there a file or another setting in the system? 
>  
> Thanks.

Locale command outputs the same: all pointing to my country.
Comment 8 Kai Uwe Broulik 2017-02-16 21:15:35 UTC 
> all pointing to my country.

And that country is..?
Comment 9 Víctor 2017-02-16 21:17:17 UTC 
(In reply to Kai Uwe Broulik from comment #8)
> > all pointing to my country.
> 
> And that country is..?

Colombia.