Created attachment 102987 [details] screencast for the problem Contiguous selection tool not always works. This often occur when you try to perform selection to the lower part of image - it newer works. But if you select region above first, then selection to the lower part of image works.. For details please see screencast attached. I didn't notified that bug before. Using appimage. krita version 3.1.1 x64.
Hi Dmitry, Is this also reproducible if you use another desktop than Unity? And which version of Ubuntu are you using?
Never mind... I've seen it happen under Gnome on OpenSUSE now.
I use Ubuntu 16.04 64bit This is reproducible under Mac OS X too. But the area where that tool does not work is smaller and located in right bottom corner.
I confirm this one also on Manjaro/XFCE + 3.1.1appimage. "Contiguous selection tool" is not alone in this problem, but the easiest to trigger/reproduce the bug. Here is a video when rectangular selection tool get also locked: https://share.kde.org/index.php/s/5ld58LjpExouKCF .In this case no workaround, just restarting Krita and loosing session.
*** Bug 375174 has been marked as a duplicate of this bug. ***
confirmed on arch linux with latest git version of krita, This is also a problem in similar color selection tool. selecting similar colors only works if the color is present in the top half if there are no similar colors in upper part of the image and all the similar colors are in the bottom half , it doesn't select anything, meanwhile if there is a color in top half of the image it selects the color in entire image even if we click on the bottom half, As if it is only sampling from the top half of the image
Same problem on Windows even for the newest update 3.1.2 However, continguous selection tool does not work for me at all. I used to use 3.0.1.1 and it was fine, but after updating I can't get the tool to work unless I'm using krita version 3.0
(In reply to onetimeisawabird from comment #7) > Same problem on Windows even for the newest update 3.1.2 > > However, continguous selection tool does not work for me at all. I used to > use 3.0.1.1 and it was fine, but after updating I can't get the tool to work > unless I'm using krita version 3.0 Also does not work for the testing build 3.1.88 Using a Surface Pro 3
I think I experience this exact bug and it appears I've found a workaround. Steps: * open an image * click with the contiguous selection tool -> selection doesn't appear * Choose Select/Reselect -> now the selection appears for the current selection and all the following ones
(In reply to Davide Olianas from comment #10) > I think I experience this exact bug and it appears I've found a workaround. > > Steps: > * open an image > * click with the contiguous selection tool -> selection doesn't appear > * Choose Select/Reselect -> now the selection appears for the current > selection and all the following ones Nice workaround, pressing Ctrl+Shift+D makes selection visible. But you have to press Ctrl+Shift+D every time whey you had no selection and use Contiguous selection tool.
(In reply to Dmitry from comment #11) > But you have to press Ctrl+Shift+D every time whey you had no selection > and use Contiguous selection tool. Obviously it's still a pain in the butt but I hope this helps in finding the bug. In the following days I'll try git bisect, hopefully I should find an old version that compiles and doesn't have the bug. In this way developers could understand where the problem is.
(In reply to Davide Olianas from comment #12) > Obviously it's still a pain in the butt but I hope this helps in finding the > bug. > > In the following days I'll try git bisect, hopefully I should find an old > version that compiles and doesn't have the bug. In this way developers could > understand where the problem is. I checked it just now: for me appimage version 3.0.1.1 does not have this bug, but 3.1.0 have it.
Yes, please -- a bisect would be super helpful!
Created attachment 104017 [details] Selection test I've done additional test. Contiguous selection tool does not work in area marked yellow. Looks like hyperbola or.. ellipse? Blue dots are circles filled by selecting with contiguous selection tool and pressing Shift+Backspace (deselect and repeat with next cell). Also as David said, any selection tools stopped working after tens of clicks.
Here is the result of git bisect 46b602ce35c920a337a31401f48d75e3c133bd71 is the first bad commit commit 46b602ce35c920a337a31401f48d75e3c133bd71 Author: Dmitry Kazakov <dimula73@gmail.com> Date: Wed Oct 19 15:22:34 2016 +0300 Crop selection outline correctly when creating a cropped selection :040000 040000 a96d2a7e81177721f60fdc1975591efeb7cdd6bf aa88065ad768294e93354cc3b3c6f4f4e3f3efa0 M libs
Put on the task list for the next release: https://phabricator.kde.org/T5353
*** Bug 376777 has been marked as a duplicate of this bug. ***
Git commit 02ac4216a4913fe3e5f69e7281c5f72a6df91c9e by Dmitry Kazakov. Committed on 25/03/2017 at 16:49. Pushed by dkazakov into branch 'kazakov/svg-loading'. Fix resetting the paint device cache on every iterator completion This bug should have happened one day. We should reset the paint device cache not only on the creation of the iterator, but also on its completion. The actual bug happened because of concurrency, while the stroke was filling the selection, an delayed updateGUI() in the status bar requested selection->selectedExactRect(), which effectively updated the cache with empty rect (which it was at that moment). And when the iterator completed with the updated seleciton, the cache was already initialized with wrong (empty) rect. Now all the iterators notify the paint device about their completion using a special interface, therefore the problem cannot happen, all the editing event will be synchronized. A +33 -0 libs/image/kis_iterator_complete_listener.h [License: GPL (v2+)] M +6 -2 libs/image/kis_paint_device.cc M +31 -8 libs/image/kis_paint_device_data.h M +12 -12 libs/image/kis_paint_device_strategies.h M +13 -11 libs/image/kis_repeat_iterators_pixel.h M +4 -2 libs/image/kis_wrapped_hline_iterator.h M +4 -2 libs/image/kis_wrapped_line_iterator_base.h M +2 -1 libs/image/kis_wrapped_random_accessor.cpp M +1 -0 libs/image/kis_wrapped_random_accessor.h M +4 -2 libs/image/kis_wrapped_vline_iterator.h M +11 -1 libs/image/tiles3/kis_base_iterator.h M +2 -2 libs/image/tiles3/kis_hline_iterator.cpp M +1 -1 libs/image/tiles3/kis_hline_iterator.h M +7 -2 libs/image/tiles3/kis_random_accessor.cc M +3 -1 libs/image/tiles3/kis_random_accessor.h M +2 -2 libs/image/tiles3/kis_vline_iterator.cpp M +1 -1 libs/image/tiles3/kis_vline_iterator.h https://commits.kde.org/krita/02ac4216a4913fe3e5f69e7281c5f72a6df91c9e
Git commit 3a50b43867cb70b10d139c5db8e1217d96217d50 by Dmitry Kazakov. Committed on 29/03/2017 at 10:03. Pushed by dkazakov into branch 'krita/3.1'. Fix resetting the paint device cache on every iterator completion This bug should have happened one day. We should reset the paint device cache not only on the creation of the iterator, but also on its completion. The actual bug happened because of concurrency, while the stroke was filling the selection, an delayed updateGUI() in the status bar requested selection->selectedExactRect(), which effectively updated the cache with empty rect (which it was at that moment). And when the iterator completed with the updated seleciton, the cache was already initialized with wrong (empty) rect. Now all the iterators notify the paint device about their completion using a special interface, therefore the problem cannot happen, all the editing event will be synchronized. A +33 -0 libs/image/kis_iterator_complete_listener.h [License: GPL (v2+)] M +6 -2 libs/image/kis_paint_device.cc M +31 -8 libs/image/kis_paint_device_data.h M +12 -12 libs/image/kis_paint_device_strategies.h M +13 -11 libs/image/kis_repeat_iterators_pixel.h M +4 -2 libs/image/kis_wrapped_hline_iterator.h M +4 -2 libs/image/kis_wrapped_line_iterator_base.h M +2 -1 libs/image/kis_wrapped_random_accessor.cpp M +1 -0 libs/image/kis_wrapped_random_accessor.h M +4 -2 libs/image/kis_wrapped_vline_iterator.h M +11 -1 libs/image/tiles3/kis_base_iterator.h M +2 -2 libs/image/tiles3/kis_hline_iterator.cpp M +1 -1 libs/image/tiles3/kis_hline_iterator.h M +7 -2 libs/image/tiles3/kis_random_accessor.cc M +3 -1 libs/image/tiles3/kis_random_accessor.h M +2 -2 libs/image/tiles3/kis_vline_iterator.cpp M +1 -1 libs/image/tiles3/kis_vline_iterator.h https://commits.kde.org/krita/3a50b43867cb70b10d139c5db8e1217d96217d50