Bug 374030 - Selecting items with rubberband doesn't make them current
Summary: Selecting items with rubberband doesn't make them current
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Desktop icons & Folder View widget (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-22 09:54 UTC by Kai Uwe Broulik
Modified: 2017-03-08 16:16 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Uwe Broulik 2016-12-22 09:54:47 UTC
In FolderView, when selecting a file with rubberband and then hitting a shortcut (e.g. F2 or Return) invokes the last-selected item instead.

1.) Select one file in FolderView by clicking the checkbox in the top left corner of it
2.) Now use rubberband to select another file

Notice how the previously selected file is no longer highlighted

3.) Now press return

Actual:
The no longer highlighted previously selected file is launched

Expected:
The file I actually selected is launched. If a selection of multiple files isn't feasible at least the top left item in the selection should be triggered.

I hardly use the checkbox at the top of an item and instead use a rubberband to select one item but then hitting Return or F2 leads to unexpected results.
Comment 1 Eike Hein 2017-01-02 11:59:15 UTC
Taking a look at tomorrow-ish.
Comment 2 Eike Hein 2017-01-03 09:45:14 UTC
Git commit 7c2e3b0d3ba872272daf1224dee5bd5ef7ae67c9 by Eike Hein.
Committed on 03/01/2017 at 09:44.
Pushed by hein into branch 'master'.

Run all selected items on Enter/Return.

Summary:
Brings FV in line with Dolphin behavior.

Reviewers: #plasma, broulik

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3933

M  +5    -2    containments/desktop/package/contents/ui/FolderView.qml
M  +11   -0    containments/desktop/plugins/folder/foldermodel.cpp
M  +1    -0    containments/desktop/plugins/folder/foldermodel.h

https://commits.kde.org/plasma-desktop/7c2e3b0d3ba872272daf1224dee5bd5ef7ae67c9
Comment 3 Kai Uwe Broulik 2017-03-08 15:56:25 UTC
I consider this bug fixed by the CC'd commit.
Comment 4 Eike Hein 2017-03-08 16:16:17 UTC
I think I actually fixed the current thing in a different one, but somehow it didn't get CC'd here :)