Bug 374029 - PDF files cannot be saved in place
Summary: PDF files cannot be saved in place
Status: RESOLVED WORKSFORME
Alias: None
Product: okular
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords: triaged
Depends on:
Blocks:
 
Reported: 2016-12-22 09:45 UTC by BasioMeusPuga
Modified: 2018-10-27 02:00 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Error message on trying to save (14.28 KB, image/png)
2016-12-23 13:17 UTC, BasioMeusPuga
Details

Note You need to log in before you can comment on or make changes to this bug.
Description BasioMeusPuga 2016-12-22 09:45:23 UTC
After the upgrade to Okular 16.12.0-1, I'm afraid it's no longer possible to save PDF files in place with Ctrl + Shift + S. 

They may be saved in another location and then copied back to the original location, but you can see how that introduces additional steps for no good reason.

This is an especially important regression in the case of saving annotations. More so because the new(?) 'Export as Document Archive' won't work with other PDF readers.
Comment 1 Albert Astals Cid 2016-12-22 22:07:22 UTC
Works fine here, could you be a bit more precise of what is the problem you get other than saying "it's no longer possible", saves for some time of me having to ask you to be precise.

Also "Export as Document Archive" is as old as it gets, and has nothing to do with this.
Comment 2 BasioMeusPuga 2016-12-23 13:17:10 UTC
Created attachment 102956 [details]
Error message on trying to save
Comment 3 BasioMeusPuga 2016-12-23 13:21:33 UTC
I'm afraid this is all the specific information I have. I'll walk through the steps to reproduce this if it helps. If it is a problem on my machine it seems to persist across all PDFs.

1. Open any PDF. I downloaded one at random after googling pdf sample.
2. Press Ctrl + Shift + S to save it in its original location.
3. Press 'Overwrite' at the overwrite file dialog box.
4. Get an error message like the attachment.

The terminal doesn't show any extra output about this error. I've also been able to replicate this across filesystems. Obey DRM is unchecked.
Comment 4 Oliver Sander 2016-12-23 15:42:51 UTC
I would guess that you are simply not allowed to write to /media/Data, which is where your browser apparently caches the pdf files you find on the internet.  To confirm, either try

touch /media/Data/foo

which I suspect will fail, or try save a pdf file that you have locally in your home directory (which I think will work).
Comment 5 BasioMeusPuga 2016-12-23 16:15:02 UTC
/media/Data (which is mounted with ntfs-3g) was the 3rd location I tried, actually. And that too was for completion's sake. I've been able to replicate this with my home folder (ext4), and /root with okular running with kdesu.

I've played around with permissions too. It doesn't work with 644 or 777.

I'll reiterate: I AM able to save the file in a new location with the Ctrl + Shift + S dialog. Just not in the same location as the existing file.
Comment 6 Albert Astals Cid 2016-12-27 21:02:28 UTC
which desktop environment do you use?

Also when you start okular, can you run this in a terminal and attach the output?

grep platformtheme /proc/`pidof okular`/maps
Comment 7 BasioMeusPuga 2016-12-28 21:41:18 UTC
I'm on Plasma 5.8.5-1 on Arch.

That command gives me:

> 7fae28675000-7fae286a7000 r-xp 00000000 fe:00 1326972                    /usr/lib/qt/plugins/platformthemes/KDEPlasmaPlatformTheme.so
> 7fae286a7000-7fae288a7000 ---p 00032000 fe:00 1326972                    /usr/lib/qt/plugins/platformthemes/KDEPlasmaPlatformTheme.so
> 7fae288a7000-7fae288a9000 r--p 00032000 fe:00 1326972                    /usr/lib/qt/plugins/platformthemes/KDEPlasmaPlatformTheme.so
> 7fae288a9000-7fae288aa000 rw-p 00034000 fe:00 1326972                    /usr/lib/qt/plugins/platformthemes/KDEPlasmaPlatformTheme.so
Comment 8 Christoph Feck 2016-12-30 15:12:09 UTC
Thanks for the update.
Comment 9 Albert Astals Cid 2016-12-31 00:36:56 UTC
You realize Ctrl+Shift+S is "Save Copy as" and not "Save as", right?

You sure you don't want Ctrl+S ?
Comment 10 BasioMeusPuga 2016-12-31 13:53:40 UTC
Oh. Oh. Oooooh.

Ctrl + S works. It's just that Ctrl + Shift + S used to work in the same fashion for so long that it just kinda became my workflow.

That said, I guess not being able to 'Save a copy' in the same place makes sense semantically. However, I'd still argue that the old behavior i.e. asking for overwrite confirmation, and then proceeding to write in place instead of erroring out - makes more sense from a usability point of view. 

This is mostly because of how non descriptive the error is, and because every other application does it like this. I would ask you to consider reverting this.

Happy new year.
Comment 11 Albert Astals Cid 2017-01-04 22:06:25 UTC
There's nothing to revert, the behaviour is the same in the old okular, just the shortcuts are different.
Comment 12 Andrew Crouthamel 2018-09-26 22:09:18 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 15 days. Please provide the requested information as soon as possible and set the bug status as REPORTED. Due to regular bug tracker maintenance, if the bug is still in NEEDSINFO status with no change in 30 days, the bug will be closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please set the bug status as REPORTED so that the KDE team knows that the bug is ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 13 Andrew Crouthamel 2018-10-27 02:00:27 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least 30 days. The bug is now closed as RESOLVED > WORKSFORME due to lack of needed information.

For more information about our bug triaging procedures please read the wiki located here: https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!