Bug 374028 - Cannot delete previously saved annotations after upgrade to 16.12.0-1
Summary: Cannot delete previously saved annotations after upgrade to 16.12.0-1
Status: RESOLVED FIXED
Alias: None
Product: okular
Classification: Applications
Component: PDF backend (show other bugs)
Version: unspecified
Platform: Arch Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Okular developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-22 09:38 UTC by BasioMeusPuga
Modified: 2016-12-22 22:11 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description BasioMeusPuga 2016-12-22 09:38:17 UTC
I believe Okular has been upgraded to KF5 with the release of 16.12.0-1. With this new version, however, annotations saved to PDF files by earlier versions can't be deleted.

Expected behavior:
Right click > Delete > Causes annotation to be deleted.

Current behavior:
Right click > Delete is grayed out.

New annotations are unaffected by this.
Comment 1 Albert Astals Cid 2016-12-22 09:42:25 UTC
Any chance you can share a pdf where this happens?
Comment 2 BasioMeusPuga 2016-12-22 09:49:36 UTC
Of course. Please have a look at the following link:

https://mega.nz/#!44M0kTxL!dOijXerRTxBiB09Q8YSW6Nbyi34IGncFO_CKmFLjFDQ

(This is a textbook so it's somewhat heavily annotated).
Comment 3 Oliver Sander 2016-12-22 09:57:19 UTC
Confirmed with today's okular git master and poppler 0.48.0.  There are annotations (e.g.) on page 2/9, and the 'Delete' menu entry in the context menu is grayed out.
Comment 4 Oliver Sander 2016-12-22 10:00:39 UTC
PS: I can delete those annotations with okular 0.26.1 from Debian testing.
Comment 5 Albert Astals Cid 2016-12-22 10:09:42 UTC
Oliver (since you seem to have both things at hand): Are the obey DRM limitations options checked the same way in 0.26.1 and git master?
Comment 6 Oliver Sander 2016-12-22 10:33:24 UTC
Yes, they are both set to "yes, do obey DRM".
Comment 7 Albert Astals Cid 2016-12-22 22:11:51 UTC
Git commit cac397dd271c7e73df739a0e85bc7b0d37e581c1 by Albert Astals Cid.
Committed on 22/12/2016 at 22:11.
Pushed by aacid into branch 'Applications/16.12'.

Fix wrong porting

We left the code for poppler < 0.22 when we should have left the other since for Qt5 poppler is always > 0.22

M  +1    -3    generators/poppler/generator_pdf.cpp

https://commits.kde.org/okular/cac397dd271c7e73df739a0e85bc7b0d37e581c1