Bug 373938 - const IRExpr arguments for matchIRExpr()
Summary: const IRExpr arguments for matchIRExpr()
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: vex (show other bugs)
Version: 3.13 SVN
Platform: Other All
: NOR normal
Target Milestone: ---
Assignee: Ivo Raisr
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-20 06:33 UTC by Ivo Raisr
Modified: 2016-12-23 12:40 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
proposed patch (46.74 KB, patch)
2016-12-20 06:33 UTC, Ivo Raisr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ivo Raisr 2016-12-20 06:33:01 UTC
Created attachment 102889 [details]
proposed patch

It should be possible to pass 'const IRExpr *' as an argument to matchIRExpr() in VEX. Neither 'pattern' or 'expr' are modified in any way.


See the attached patch which builds cleanly on Linux and Solaris.
Comment 1 Ivo Raisr 2016-12-21 08:55:45 UTC
So the gist of my changes is really just:
- Bool matchIRExpr ( MatchInfo* mi, IRExpr* p, IRExpr* e );
+ Bool matchIRExpr ( MatchInfo* mi, const IRExpr* p, const IRExpr* e );
Comment 2 Ivo Raisr 2016-12-23 12:40:56 UTC
Fixed in Valgrind r16191 (NEWS) and VEX r3288.