Bug 373821 - Crash when edditing text, also text button are not displayed
Summary: Crash when edditing text, also text button are not displayed
Status: RESOLVED UNMAINTAINED
Alias: None
Product: krita
Classification: Applications
Component: Tool/Text (show other bugs)
Version: 3.1.1
Platform: Microsoft Windows Microsoft Windows
: NOR critical
Target Milestone: ---
Assignee: Krita Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-18 13:49 UTC by Rafal
Modified: 2017-12-30 10:52 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Bug with text tool (1.08 MB, image/png)
2016-12-18 13:49 UTC, Rafal
Details
Krash log (45.02 KB, text/plain)
2016-12-22 12:35 UTC, Rafal
Details
Another crash (18.15 KB, text/plain)
2016-12-23 15:42 UTC, Rafal
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Rafal 2016-12-18 13:49:22 UTC
Created attachment 102855 [details]
Bug with text tool

When i played around with text tool (multiline) options like bold an align program crashed. I attached files showing error. Also i highlignt the missing buttons area. They are working if i push them, but they are invisible...

On the attached file I was edditing japanese kanji font, but it is the same with usuall alphabet.
Comment 1 Halla Rempt 2016-12-22 12:07:04 UTC
Hi Rafal, 

While it is know that the text tool has many problems, which is why it's going to be replaced early next year, I cannot reproduce your crash. Could you follow the instructions here: https://docs.krita.org/Dr._Mingw_debugger and reproduce the crash and add a backtrace? Otherwise there isn't much we can do with your report :-(
Comment 2 Rafal 2016-12-22 12:35:16 UTC
Created attachment 102942 [details]
Krash log
Comment 3 Rafal 2016-12-22 12:41:02 UTC
Hey Boudewijn

I attached log. I believe the first two crashes are related to text tool. There is a 3rd crash also, but i am not sure what happen then, i simply don't remember.

I read recently that you are gonna rewrite text tool completaly. If that is the case then don't worry to much about this bug. It's good if you look into it, but having totaly new text tool seems more apealing :)

Thank you for your hard work on Krita, and Merry Christmas.
Comment 4 Halla Rempt 2016-12-22 15:04:56 UTC
Git commit 985de0717a4e117104e6d25e8de524f0b02ee918 by Boudewijn Rempt.
Committed on 22/12/2016 at 15:03.
Pushed by rempt into branch 'master'.

This seems to happen in the change tracker, according to the
backtrace for this bug. Well, we don't need no changetracker in
Krita (it's not the thing that's used for undo), so remove all
this highly complex code and let's hope that tonight's nightly
build on https://ci.appveyor.com/project/alvinhochun/krita/build/artifacts
doesn't crash anymore.

M  +2    -121  plugins/flake/textshape/kotext/KoTextEditor.cpp

https://commits.kde.org/krita/985de0717a4e117104e6d25e8de524f0b02ee918
Comment 5 Halla Rempt 2016-12-22 15:05:48 UTC
Yes... Those happen in the text tool, in the changetracker code we inherited from Calligra Words. I've simply removed that code, and maybe you can check whether tonight's nightly works better for you?

And merry Christmas to you, too!
Comment 6 Rafal 2016-12-22 15:17:04 UTC
Because i am working with commission right now, i do not want to mess with different versions of Krita (just in case) I will patiently wait for next stable release. I will probably avoid text tool's options until new one will be implemented.
Comment 7 Halla Rempt 2016-12-23 08:40:51 UTC
The debug version is a standalone zip that shouldn't interfere with your existing installation at all. But... If you're on a commission, don't bother. We'll be redoing this code _anyway_.
Comment 8 Rafal 2016-12-23 15:42:59 UTC
Created attachment 102958 [details]
Another crash

Hey, i just got another crash. This is also related to text tool but it is more severe. Krita creashed 3 times at the moment i choose multiline and then drag on canvas to draw text box. At that moment got crash. So i could not even write anything or choose for etc.

Can you check if this crash is also related to the very same line as previous one you found in code? If yes then i guess i will have to download the newer version.

Thanks
Comment 9 Halla Rempt 2017-12-30 10:52:31 UTC
We just merged the new text tool.