Bug 373715 - Renaming popup stays when file with new name already exists
Summary: Renaming popup stays when file with new name already exists
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: AdvancedRename-dialog (show other bugs)
Version: 5.3.0
Platform: Other Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-16 11:06 UTC by Simon
Modified: 2022-02-01 06:31 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 5.4.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon 2016-12-16 11:06:57 UTC
Steps to reproduce:
1. Select item and open advanced rename tool.
2. Change filename to a name for which there is already a file in the same album.

This creates a popup titled "Renaming images - digiKam" which goes to 100% and then stays there unless one manually presses "Abort". There is also a notification in the bottom right saying that there is already a file with that name.

Best case would be a dialog asking whether I really want to overwrite the file, abort or return to rename tool to change the filename. At the very least make the popup meaningful, e.g. saying "Could not rename ..., as there is already a file with that name.", so essentially the same as the notification on the bottom right. Or just make the popup disappear automatically and hope the user sees the notification in the bottom right corner.
Comment 1 Simon 2016-12-16 11:07:36 UTC
I forgot the screenshot:
http://i.imgur.com/jyUkL0n.png
Comment 2 Maik Qualmann 2016-12-16 19:44:09 UTC
Git commit ff064c7e1a6335687f5e19b33d2b0e8b8356c7bb by Maik Qualmann.
Committed on 16/12/2016 at 19:43.
Pushed by mqualmann into branch 'master'.

add a check to the advanced rename dialog if the new file already exists and mark item as invalid
FIXED-IN: 5.4.0

M  +2    -1    NEWS
M  +2    -1    utilities/advancedrename/advancedrenamedialog.cpp

https://commits.kde.org/digikam/ff064c7e1a6335687f5e19b33d2b0e8b8356c7bb