Bug 373686 - German names for the christmas holidays are wrong
Summary: German names for the christmas holidays are wrong
Alias: None
Product: frameworks-kholidays
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: kdepim bugs
Depends on:
Reported: 2016-12-15 14:25 UTC by Tobias Leupold
Modified: 2018-03-26 17:36 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:

Screenshot (40.20 KB, image/jpeg)
2016-12-16 11:41 UTC, Tobias Leupold
Proposed patch for the German/Bavarian files (4.34 KB, patch)
2016-12-16 16:21 UTC, Tobias Leupold

Note You need to log in before you can comment on or make changes to this bug.
Description Tobias Leupold 2016-12-15 14:25:34 UTC
With version 16.04.3, both December 25 and 26 are named "Weihnachten".

Imho, the correct name would be "1. Weihnachtsfeiertag" for December 25 and "2. Weihnachtsfeiertag" for December 26.

If you don't want to call December 24 "Weihnachten" but "Heiliger Abend", I would suggest to put the written-out name there instead of "Hl. Abend".

Cheers, Tobias
Comment 1 Burkhard Lück 2016-12-16 08:29:13 UTC
l10n-kf5/de/messages has no translation "Weihnachten".

Where do you see this translation?
Comment 2 Tobias Leupold 2016-12-16 11:41:06 UTC
Created attachment 102813 [details]

It shows up when clicking the respective day on the calendar, cf. the attached screenshot.
Comment 3 Allen Winter 2016-12-16 15:31:59 UTC

look in the kholidays repo, there should be a plan2/holiday_de_de
Comment 4 Tobias Leupold 2016-12-16 16:21:39 UTC
Created attachment 102819 [details]
Proposed patch for the German/Bavarian files

Only having had a fast look at the sources, this is what I would propose to change, just to get the spelling right firstly.
Comment 5 Tobias Leupold 2016-12-16 16:27:21 UTC
I mean, (speaking of the "Bavarian" thingy) the "Wies'n-Sonntag" is surely not a holiday for example. If we add such days, we would also have to add the Gäubodenfest, the Anafest, the Sandkerwa, the Bergkirchweih and so on. I personally would remove such stuff if we want to be serious, but that's another Bug ;-)
Comment 6 Tobias Leupold 2016-12-16 17:13:58 UTC
If you say "Do it", I'll rework the German holidays files (I think they need it). But I would not push to this repository without asking first ...
Comment 7 Tobias Leupold 2018-03-24 12:41:18 UTC
Just now, I'm seeing the Passion Week and the calendar displaying me "Karwoche" for each day. Along with that "1./2./3. Fastensonntag", "Palmsonntag" and whatnot. This really needs to be reworked. Those aren't official holidays and thus should (if at all) go to a specialized religios calendar file or whatever.

If nobody maintains this (apparently nobody does?!), I'll rework it according to the official German ("bundeseinheitliche") and Bavarian Holidays and puh it, okay?
Comment 8 Tobias Leupold 2018-03-26 17:36:18 UTC
Git commit d70b7e33ba9b12add232ae331a5cf69db14cef24 by Tobias Leupold.
Committed on 26/03/2018 at 17:35.
Pushed by tleupold into branch 'master'.

Reworked the holiday files for Germany.

Fixed the common holidays for all federal states according to official
sources, and added a file for each federal state that has additional
holidays. Also fixed (more rewrote) the existing one for Bavaria.

M  +11   -0    holidays/holidays.qrc
A  +66   -0    holidays/plan2/holiday_de-bb_de
A  +69   -0    holidays/plan2/holiday_de-bw_de
M  +43   -65   holidays/plan2/holiday_de-by_de
A  +67   -0    holidays/plan2/holiday_de-hh_de
A  +66   -0    holidays/plan2/holiday_de-mv_de
A  +67   -0    holidays/plan2/holiday_de-nw_de
A  +67   -0    holidays/plan2/holiday_de-rp_de
A  +66   -0    holidays/plan2/holiday_de-sh_de
A  +68   -0    holidays/plan2/holiday_de-sl_de
A  +68   -0    holidays/plan2/holiday_de-sn_de
A  +67   -0    holidays/plan2/holiday_de-st_de
A  +67   -0    holidays/plan2/holiday_de-th_de
M  +32   -28   holidays/plan2/holiday_de_de