Bug 373654 - Missing media-mount action icon in Oxygen icon theme
Summary: Missing media-mount action icon in Oxygen icon theme
Status: RESOLVED FIXED
Alias: None
Product: Oxygen
Classification: Plasma
Component: icons (show other bugs)
Version: 5.8.4
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: pinheiro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-14 18:38 UTC by Michal Ziabkowski
Modified: 2018-03-21 19:19 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Ziabkowski 2016-12-14 18:38:18 UTC
The oxygen icon theme are missing the media-mount action icon, which is used by the device notifier following commit ec87c140122c7343fd1bca219d0a394d07bdc5b7. The icon in question is only present in the breeze and breeze-dark icon themes. This leads to the mount action being hard to discover, since no icon is displayed unless using the breeze and breeze-dark themes.

The problem can be easily worked around by copying the old emblems/emblem-mounted icon, but an upstream fix would be appreciated.
Comment 1 Christoph Feck 2016-12-20 22:11:50 UTC
I locally symlinked to ../emblems/emblem-mounted.png but letting VDG to decide what to do with this ticket.
Comment 2 Gunter Ohrner 2017-01-06 10:53:30 UTC
Confirmed - also missing in KDE Neon.

An official fix would be appreciated - otherwise external device handling in KDE 5 with Oxygen Icon theme get's really confusing if you do not know what happens behind the scenes and that you have to click into empty space in the mass storage notification to actually mount the external drive...
Comment 3 andreas 2018-02-09 14:00:57 UTC
Git commit b5acc2008abd54e0ba96d8730f606c2e628b300c by andreas kainz.
Committed on 09/02/2018 at 14:05.
Pushed by andreask into branch 'master'.

link emblem-mount to media-mount

A  +1    -0    16x16/emblems/media-mount.png
A  +1    -0    22x22/emblems/media-mount.png
A  +1    -0    48x48/emblems/media-mount.png

https://commits.kde.org/oxygen-icons5/b5acc2008abd54e0ba96d8730f606c2e628b300c
Comment 4 Wolfgang Bauer 2018-03-14 08:32:45 UTC
(In reply to andreas from comment #3)
> Git commit b5acc2008abd54e0ba96d8730f606c2e628b300c by andreas kainz.
> Committed on 09/02/2018 at 14:05.
> Pushed by andreask into branch 'master'.
> 
> link emblem-mount to media-mount
> 
> A  +1    -0    16x16/emblems/media-mount.png
> A  +1    -0    22x22/emblems/media-mount.png
> A  +1    -0    48x48/emblems/media-mount.png
> 
> https://commits.kde.org/oxygen-icons5/
> b5acc2008abd54e0ba96d8730f606c2e628b300c

I'm no expert on icon themes, but shouldn't the media-mount icons be in /actions/ like in breeze?
Comment 5 Gunter Ohrner 2018-03-15 19:58:07 UTC
At least in KDE Neon Oxygen Icons version 5:5.43.0-0neon+16.04+xenial+build36 it's still not fixed.
Comment 6 Gunter Ohrner 2018-03-16 14:38:03 UTC
(In reply to Gunter Ohrner from comment #5)
> At least in KDE Neon Oxygen Icons version
> 5:5.43.0-0neon+16.04+xenial+build36 it's still not fixed.

This package already contains the copied files:

$ dpkg -L oxygen-icon-theme | egrep mount
/usr/share/icons/oxygen/base/22x22/emblems/emblem-mounted.png
/usr/share/icons/oxygen/base/22x22/emblems/emblem-unmounted.png
/usr/share/icons/oxygen/base/8x8/emblems/emblem-mounted.png
/usr/share/icons/oxygen/base/8x8/emblems/emblem-unmounted.png
/usr/share/icons/oxygen/base/32x32/emblems/emblem-mounted.png
/usr/share/icons/oxygen/base/32x32/emblems/emblem-unmounted.png
/usr/share/icons/oxygen/base/128x128/emblems/emblem-mounted.png
/usr/share/icons/oxygen/base/64x64/emblems/emblem-mounted.png
/usr/share/icons/oxygen/base/48x48/emblems/emblem-mounted.png
/usr/share/icons/oxygen/base/16x16/emblems/emblem-mounted.png
/usr/share/icons/oxygen/base/16x16/emblems/emblem-unmounted.png
/usr/share/icons/oxygen/base/22x22/emblems/media-mount.png
/usr/share/icons/oxygen/base/48x48/emblems/media-mount.png
/usr/share/icons/oxygen/base/16x16/emblems/media-mount.png
$

So it really is not fixed and probably Wolfgang's assumption is right.
Comment 7 Wolfgang Bauer 2018-03-17 14:46:45 UTC
(In reply to Gunter Ohrner from comment #5)
> At least in KDE Neon Oxygen Icons version
> 5:5.43.0-0neon+16.04+xenial+build36 it's still not fixed.

Erm, the fix is only in 5.44.0...

(In reply to Gunter Ohrner from comment #6)
> This package already contains the copied files:

Well, check that the symlinks really point to the proper files, and try to delete the icon cache (~/.cache/iconcache.kcache).

> So it really is not fixed and probably Wolfgang's assumption is right.

My "assumption" is just that the icons should rather belong to /actions/ for organizational reasons.
AFAIK it should not matter in regards to this bug that they are in /emblems/ instead (otherwise I would have reopened it).

The problem is fixed here on openSUSE with oxygen-icon-theme 5.44.0.
Comment 8 Gunter Ohrner 2018-03-17 21:33:27 UTC
(In reply to Wolfgang Bauer from comment #7)
> > At least in KDE Neon Oxygen Icons version
> > 5:5.43.0-0neon+16.04+xenial+build36 it's still not fixed.
> Erm, the fix is only in 5.44.0...

Ok, sorry, did not find any indication about in which package version it's actually fixed. ("Target Milestone" is not set and I also could not find this information by following the "Latest Commit" link.)

Apparently, my assumptions about which it was were wrong.


I'm also on 5.44.0 now and the icon is visible.


> My "assumption" is just that the icons should rather belong to /actions/ for
> organizational reasons.
> AFAIK it should not matter in regards to this bug that they are in /emblems/
> instead (otherwise I would have reopened it).

Ok - however I doubt that someone will see and amend this if this bug is closed...

As it works and I'm neither the one who reported the bug nor the one who found the organisational problem I'll just stop meddling with it and close the bug again.
Comment 9 Wolfgang Bauer 2018-03-21 19:19:19 UTC
(In reply to Gunter Ohrner from comment #8)
> Ok - however I doubt that someone will see and amend this if this bug is
> closed...

People subscribed do get notifications about new comments even if the bug is "RESOLVED". ;-)