Created attachment 102764 [details] [patch] openvpn: rename comp-lzo setting "No by default" in the UI Quote: openvpn: rename comp-lzo setting "No by default" in the UI To express a "comp-lzo no" setting in nm-openvpn, it must be stored as "comp-lzo=no-by-default". That is to preserve backward compatiblity, where older versions would wrongly set "comp-lzo=no" to mean LZO compression disabled [1]. This "no-by-default" term is only relevant for the connection, the UI should call it "no", like openvpn's manual page. [1] https://git.gnome.org/browse/network-manager-openvpn/commit/?id=62bdd278d69cc396479af9d05a0b776d5ad386bf
Git commit c6d6d380f9133e1286a9022e9895d28b5c7dcb45 by Jan Grulich, on behalf of Thomas Haller. Committed on 13/12/2016 at 13:54. Pushed by grulich into branch 'master'. openvpn: rename comp-lzo setting "No by default" in the UI To express a "comp-lzo no" setting in nm-openvpn, it must be stored as "comp-lzo=no-by-default". That is to preserve backward compatiblity, where older versions would wrongly set "comp-lzo=no" to mean LZO compression disabled [1]. This "no-by-default" term is only relevant for the connection, the UI should call it "no", like openvpn's manual page. [1] https://git.gnome.org/browse/network-manager-openvpn/commit/?id=62bdd278d69cc396479af9d05a0b776d5ad386bf M +1 -1 vpn/openvpn/openvpnadvanced.ui https://commits.kde.org/plasma-nm/c6d6d380f9133e1286a9022e9895d28b5c7dcb45