Bug 373579 - Battery label is cut off on small (hidpi) panels
Summary: Battery label is cut off on small (hidpi) panels
Status: RESOLVED WORKSFORME
Alias: None
Product: plasmashell
Classification: Plasma
Component: Power and Battery widget (show other bugs)
Version: master
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Kai Uwe Broulik
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-12 18:16 UTC by Martin Klapetek
Modified: 2019-12-14 04:33 UTC (History)
3 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Bug screenshot (4.27 KB, image/png)
2016-12-12 18:16 UTC, Martin Klapetek
Details
on ~200 dpi (10.82 KB, image/png)
2016-12-15 14:23 UTC, Marco Martin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Klapetek 2016-12-12 18:16:39 UTC
Created attachment 102747 [details]
Bug screenshot

I'm not entirely sure if there is a proper fix as the panel may simply be too small to fit the whole label with the badge, however I'd assume that it's not uncommon to have this high panel on hidpi screens.
Comment 1 Kai Uwe Broulik 2016-12-12 18:18:23 UTC
Yeah, pretty large compared to the rest on my laptop as well. Sorry, haven't bothered testing the patch on high dpi :)
Comment 2 Marco Martin 2016-12-15 14:09:04 UTC
seems smallestreadablefont isn't really smallest readable font at all on high dpi :/
Comment 3 Marco Martin 2016-12-15 14:23:12 UTC
Created attachment 102796 [details]
on ~200 dpi

here on 190-something dpi, seems fine, problem is units havig wildly different values on different systems i guess
Comment 4 Martin Klapetek 2016-12-15 17:45:48 UTC
The problem is that my panel is definitely smaller than yours on the screenshot. I mean, it's hidpi, I don't need a massive panel to be able to read everything.

As for units being different on different systems - there's a font type in play as well, as was addressed by https://git.reviewboard.kde.org/r/125773/
Comment 5 Marco Martin 2016-12-21 11:23:59 UTC
(In reply to Martin Klapetek from comment #4)
> The problem is that my panel is definitely smaller than yours on the
> screenshot. I mean, it's hidpi, I don't need a massive panel to be able to
> read everything.
> 
> As for units being different on different systems - there's a font type in
> play as well, as was addressed by https://git.reviewboard.kde.org/r/125773/

but thing is, that label should go all down to smallestreadablefont, if that font is too big, is a problem of the font itself, not really of how the units gets calculated (so i don't think that old patch would really solve things)
Comment 6 Nate Graham 2019-11-14 03:01:59 UTC
Is this issue reproducible when using scaling in the Displays KCM and possibly setting PLASMA_USE_QT_SCALING=1 set in your env instead of manually adjusting the DPI?
Comment 7 Bug Janitor Service 2019-11-29 04:33:08 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 8 Bug Janitor Service 2019-12-14 04:33:08 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!