Bug 373566 - no more desktop icons installed during build
Summary: no more desktop icons installed during build
Status: RESOLVED FIXED
Alias: None
Product: kalzium
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Mageia RPMs Linux
: NOR normal
Target Milestone: ---
Assignee: Kalzium Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-12 10:48 UTC by David Geiger
Modified: 2016-12-20 20:22 UTC (History)
0 users

See Also:
Latest Commit: https://commits.kde.org/kalzium/f7dd9799fc7dc25de03a2e2ad9d57764f967f2fa
Version Fixed In: 16.12.1

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description David Geiger 2016-12-12 10:48:52 UTC 
Hi,

build latest 16.11.90 release doesn't install icons anymore due to commented line 75 in the CMakeLists.txt file:

# set (KDE4_ICON_DIR  ${CMAKE_INSTALL_PREFIX}/share/icons)
Comment 1 David Geiger 2016-12-13 09:35:45 UTC 
Hmmm! I'm wrong, I meant the desktop icons in /src/CMakeLists.txt at line 195 :

#kde4_install_icons(${ICON_INSTALL_DIR})
Comment 2 David Geiger 2016-12-13 11:00:29 UTC 
Si here is a fix:

1) rename all desktop icons for:

for png in 16 22 32 48 64 128; do
mv src/hi$png-app-kalzium.png src/$png-apps-kalzium.png
done
mv src/hisc-app-kalzium.svgz src/sc-apps-kalzium.svgz

2) use "ecm_install_icons" to install all desktop icons:

diff -Nru a/src/CMakeLists.txt b/src/CMakeLists.txt
--- a/src/CMakeLists.txt	2016-11-12 16:43:16.000000000 +0100
+++ b/src/CMakeLists.txt	2016-12-13 10:56:38.672358722 +0100
@@ -192,4 +192,9 @@
 install(FILES kalziumui.rc DESTINATION ${KXMLGUI_INSTALL_DIR}/kalzium)
 install(FILES kalzium.knsrc DESTINATION ${CONFIG_INSTALL_DIR})
 
-#kde4_install_icons(${ICON_INSTALL_DIR})
+file(GLOB icons "*.png" "*.svgz")
+ecm_install_icons(
+    ICONS ${icons}
+    DESTINATION ${ICON_INSTALL_DIR}
+    THEME hicolor
+)
Comment 3 David Geiger 2016-12-16 23:24:42 UTC 
Ping?
Comment 4 Christoph Feck 2016-12-20 20:22:56 UTC 
Git commit f7dd9799fc7dc25de03a2e2ad9d57764f967f2fa by Christoph Feck.
Committed on 20/12/2016 at 20:17.
Pushed by cfeck into branch 'Applications/16.12'.

Fix app icon installation

Investigation and initial patch by David Geiger
FIXED-IN: 16.12.1

R  +-    --    src/128-apps-kalzium.png [from: src/hi128-app-kalzium.png - 100% similarity]
R  +-    --    src/16-apps-kalzium.png [from: src/hi16-app-kalzium.png - 100% similarity]
R  +-    --    src/22-apps-kalzium.png [from: src/hi22-app-kalzium.png - 100% similarity]
R  +-    --    src/32-apps-kalzium.png [from: src/hi32-app-kalzium.png - 100% similarity]
R  +-    --    src/48-apps-kalzium.png [from: src/hi48-app-kalzium.png - 100% similarity]
R  +-    --    src/64-apps-kalzium.png [from: src/hi64-app-kalzium.png - 100% similarity]
M  +11   -1    src/CMakeLists.txt
R  +-    --    src/sc-apps-kalzium.svgz [from: src/hisc-app-kalzium.svgz - 100% similarity]

https://commits.kde.org/kalzium/f7dd9799fc7dc25de03a2e2ad9d57764f967f2fa