Bug 373555 - Rename BBPTR to GSPTR as it denotes guest state pointer only
Summary: Rename BBPTR to GSPTR as it denotes guest state pointer only
Status: RESOLVED FIXED
Alias: None
Product: valgrind
Classification: Developer tools
Component: vex (other bugs)
Version First Reported In: 3.13 SVN
Platform: Compiled Sources All
: NOR minor
Target Milestone: ---
Assignee: Ivo Raisr
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-12 04:14 UTC by Ivo Raisr
Modified: 2016-12-16 21:21 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
patch for VEX (46.86 KB, patch)
2016-12-12 04:18 UTC, Ivo Raisr 		Details
patch for Valgrind (1.29 KB, patch)
2016-12-12 04:18 UTC, Ivo Raisr 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Ivo Raisr 2016-12-12 04:14:05 UTC 
VEX currently contains a fossil called "BBPTR", which meant basic block pointer (maybe in some distant past). However through all the VEX, it is used with the meaning of "GSPTR", that is guest state pointer.
It is really confusing to read all over the code about BBPTR but in reality GSPTR is meant.

The attached patch renames BBPTR to GSPTR and fixes also corresponding comments.
Comment 1 Ivo Raisr 2016-12-12 04:18:26 UTC 
Created attachment 102737 [details]
patch for VEX
Comment 2 Ivo Raisr 2016-12-12 04:18:56 UTC 
Created attachment 102738 [details]
patch for Valgrind
Comment 3 Ivo Raisr 2016-12-16 21:21:31 UTC 
Fixed in SVN Valgrind r16189, VEX r3287.