Bug 373544 - Task manager: no text on small items
Summary: Task manager: no text on small items
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Task Manager and Icons-Only Task Manager widgets (show other bugs)
Version: 5.7.5
Platform: Other Linux
: NOR normal
Target Milestone: 1.0
Assignee: Eike Hein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-11 21:30 UTC by Roman Odaisky
Modified: 2017-01-11 10:28 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Size without labels (5.75 KB, image/png)
2017-01-01 21:51 UTC, Kai Uwe Broulik
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Odaisky 2016-12-11 21:30:28 UTC
When task manager items get small due to a large number of items, only icons are shown and the text disappears. The problem is, this starts way too early, when the items can still display meaningful text.

This is defined as a magic number, currently 7 (units are seemingly em), in a QML file[1]. Please lower this value to about 3 or, better, make it configurable.

[1] https://github.com/KDE/plasma-desktop/blob/Plasma/5.8/applets/taskmanager/package/contents/ui/Task.qml#L402
Comment 1 Eike Hein 2016-12-12 10:16:33 UTC
Why is 3 a better magic number than 7? It might be, but could you add some good screenshots for justification?
Comment 2 Kai Uwe Broulik 2017-01-01 21:51:20 UTC
Created attachment 103133 [details]
Size without labels

I agree, in the screenshot is the size at which it starts to hide labels, there would still be plenty of room to be able to tell apart those folders.
Comment 3 Eike Hein 2017-01-02 11:57:51 UTC
Agreed (this is a lot bigger than I remember it setting as, wonder if bitrot set in somehow).
Comment 4 Eike Hein 2017-01-03 07:47:00 UTC
Ok, so I think there's something more to consider here, namely vertical panels. With the current value of 7, with most common vertical panel widths, the text label will currently be collapsed, leaving only the icons. If I lower the value to 3, many common vertical panel widths will end up with (very little) text shown. On the face of it this makes sense, since wanting text labels is a reason to use the regular Task Manager over the Icons-only version, and people who don't want text could just use Icons-only. However for historical reasons, there's more difference between the two applets than that ... the ITM has slightly different default options and slightly different (less) settings available, as it's our "this satisfies your dock cravings" applet.

Basically, if I lower this value to 3 as the only change, I know it's going to piss some users off who want a "clean" icon task bar in ther vert panel but still regular TM behavior and options. Instead I could go with 5, which is just outside typical panel widths used by such users. That's the lowest I could go without opening this can of worms for now (which may have to be opened eventually).

Please try this out with:

  plasmoidviewer --formfactor vertical --applet org.kde.plasma.taskmanager

And let me know your opinions.
Comment 5 Eike Hein 2017-01-11 10:28:32 UTC
Git commit 3d98fa78831ed823c229810461d2d8cbf9521cb5 by Eike Hein.
Committed on 11/01/2017 at 10:27.
Pushed by hein into branch 'master'.

Lower the threshold below which text labels collapse.

Magic number chosen by fair dice ro... feedback.

M  +1    -1    applets/taskmanager/package/contents/ui/Task.qml

https://commits.kde.org/plasma-desktop/3d98fa78831ed823c229810461d2d8cbf9521cb5