Bug 373531 - git master - Breeze icons aren't showing on fresh rebuild of git master on Arch [screenshot included]
Summary: git master - Breeze icons aren't showing on fresh rebuild of git master on Ar...
Status: RESOLVED FIXED
Alias: None
Product: kdenlive
Classification: Applications
Component: User Interface & Miscellaneous (show other bugs)
Version: git-master
Platform: Arch Linux Linux
: VHI major
Target Milestone: ---
Assignee: Jean-Baptiste Mardelle
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-11 19:03 UTC by Unknown
Modified: 2016-12-17 19:35 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
screenshot of issue (1.28 MB, image/png)
2016-12-11 19:03 UTC, Unknown
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Unknown 2016-12-11 19:03:14 UTC
Created attachment 102729 [details]
screenshot of issue

I used the AUR to re-build the latest git of Kdenlive master, and ran into an issue after running the program: the icons of Kdenlive are the faenza icons (my system icons), not the Breeze icons, even though both theme and style settings are set to "Breeze".

Bug discovered while using Kdenlive 17.03.70 git master ppa on Antergos (Arch) Linux x64, GNOME 3.22.2 desktop environment, Xorg 1.18.4, kernel 4.8.12-13 ARCH.
Comment 1 Unknown 2016-12-11 19:14:34 UTC
UPDATE: running from Terminal shows these errors before Kdenlive window appears.

Invalid Type= "fixed" line for icon theme:  "/usr/share/icons/Faenza-Dark/actions/16/"
Invalid Context= "Apps" line for icon theme:  "/usr/share/icons/Faenza-Dark/apps/16/"
Invalid Type= "fixed" line for icon theme:  "/usr/share/icons/Faenza-Dark/categories/16/"
Invalid Type= "fixed" line for icon theme:  "/usr/share/icons/Faenza-Dark/status/16/"
Invalid Type= "fixed" line for icon theme:  "/usr/share/icons/Faenza-Dark/actions/22/"
Comment 2 farid 2016-12-13 00:12:06 UTC
I confirm. This is an important one for 16.12 if you could look at it JB. 

Cheers
Comment 3 Unknown 2016-12-13 00:13:44 UTC
Thanks for confirming Farid!
Comment 4 Jean-Baptiste Mardelle 2016-12-15 19:03:00 UTC
I have not been able to confirm using Kdenlive's master PPA on Ubuntu with a Gnome desktop. I will do more tests in the next days
Comment 5 farid 2016-12-15 19:03:57 UTC
(In reply to Jean-Baptiste Mardelle from comment #4)
> I have not been able to confirm using Kdenlive's master PPA on Ubuntu with a
> Gnome desktop. I will do more tests in the next days

ok, let me know in case i can take it to the arch devs.
Comment 6 Unknown 2016-12-15 19:05:51 UTC
Thanks so much for looking into this, all! :)
Comment 7 François 2016-12-16 09:58:35 UTC
Same for me on Debian Stretch also using Gnome. I have tried to switch off and on again "Force Breeze Icon Theme" but without success.

This problem wasn't present during the bug squashing day.

The app is still usable but the UI is not as nice and efficient as it should be.

Thanks!
Comment 8 Jean-Baptiste Mardelle 2016-12-16 10:04:56 UTC
François, I suspect this may be a consequence of the following commit:
https://cgit.kde.org/kdenlive.git/commit/?id=c4f1aa9d8284d50274254fc1f56c08daf7bc5b89

The part changed in main.cpp. Could you try to revert that change to see if it fixes the problem?
Comment 9 Unknown 2016-12-16 18:24:49 UTC
I can confirm that checking/unchecking the Force Breeze Icon theme does nothing for me on Arch, either.
Comment 10 François 2016-12-16 20:43:14 UTC
JB, OK, I will check that as soon as I get the time (maybe tomorrow)
Comment 11 François 2016-12-16 21:31:57 UTC
JB, I have just tested the revert and it fixes the issue indeed!
Comment 12 Jean-Baptiste Mardelle 2016-12-17 09:42:53 UTC
Git commit 215457f670b78c5f6fdd9a2adb6173496b9bedf2 by Jean-Baptiste Mardelle.
Committed on 17/12/2016 at 09:42.
Pushed by mardelle into branch 'Applications/16.12'.

Move DBus and force icon theme above KAboutData

M  +12   -10   src/main.cpp

https://commits.kde.org/kdenlive/215457f670b78c5f6fdd9a2adb6173496b9bedf2
Comment 13 Jean-Baptiste Mardelle 2016-12-17 09:43:47 UTC
Git commit d07325aca898b3819bd284efa67bbf1e742bfdcd by Jean-Baptiste Mardelle.
Committed on 17/12/2016 at 09:43.
Pushed by mardelle into branch 'master'.

Move DBus and force icon theme above KAboutData

M  +12   -10   src/main.cpp

https://commits.kde.org/kdenlive/d07325aca898b3819bd284efa67bbf1e742bfdcd
Comment 14 Unknown 2016-12-17 19:35:55 UTC
Fix confirmed in the latest git build. Icons are Breeze, again! Thanks JB! Marking bug as resolved/fixed.