Created attachment 102722 [details] Full log of a failed build Trying to build kmplayer 0.12.0b for the upcoming release of Rosa Linux x86_64 (a Mandriva derivative). Using KF5 5.27 and Qt5 5.6.2; gcc 5.3.1 and cmake 3.6.1. The build fails at kmplayerplaylist.cpp with a couple of errors: ******************************** /tmp/abf/rpmbuild/BUILD/kmplayer-0.12.0b/src/kmplayerplaylist.cpp: In function 'void KMPlayer::readXML(KMPlayer::NodePtr, QTextStream&, const QString&, bool)': /tmp/abf/rpmbuild/BUILD/kmplayer-0.12.0b/src/kmplayerplaylist.cpp:1602:29: error: 'class QString' has no member named 'utf8' QByteArray ba = str.utf8 (); ^ /tmp/abf/rpmbuild/BUILD/kmplayer-0.12.0b/src/kmplayerplaylist.cpp:1609:34: error: no matching function for call to 'QTextStream::read()' QByteArray ba = in.read ().utf8 (); ^ In file included from /tmp/abf/rpmbuild/BUILD/kmplayer-0.12.0b/src/kmplayerplaylist.cpp:22:0: /usr/include/qt5/QtCore/qtextstream.h:129:13: note: candidate: QString QTextStream::read(qint64) QString read(qint64 maxlen); ^ /usr/include/qt5/QtCore/qtextstream.h:129:13: note: candidate expects 1 argument, 0 provided *************************** Qt version mismatch?
Does applying https://cgit.kde.org/kmplayer.git/patch/?id=8b5d375c25555d9a5c3984d6e6f21a6b8d3e5afa then compile? I have no idea why it compiled for me, its old qt3 code.
(In reply to Koos Vriezen from comment #1) > Does applying > https://cgit.kde.org/kmplayer.git/patch/ > ?id=8b5d375c25555d9a5c3984d6e6f21a6b8d3e5afa > then compile? > I have no idea why it compiled for me, its old qt3 code. No, it solves only the first issue... This one is still present: /tmp/abf/rpmbuild/BUILD/kmplayer-0.12.0b/src/kmplayerplaylist.cpp:1609:34: error: no matching function for call to 'QTextStream::read()' ... /usr/include/qt5/QtCore/qtextstream.h:129:13: note: candidate expects 1 argument, 0 provided
Ah yes, follow-up patch at https://cgit.kde.org/kmplayer.git/patch/?id=271ccae67d6efcb574e1791827d61a285b771687 Compiles now?
(In reply to Koos Vriezen from comment #3) > Ah yes, follow-up patch at > https://cgit.kde.org/kmplayer.git/patch/ > ?id=271ccae67d6efcb574e1791827d61a285b771687 > > Compiles now? With the above git commit surely no... The change is the same as in the second part of 8b5d375c25555d9a5c3984d6e6f21a6b8d3e5afa, so it was already applied when I got the other failure. AFAICT the issue number two is that the definition of qtextstream from qt5 headers does not match the one used by kmplayerplaylist.cpp at line 22 (in the log the output is mixed because I'm building with -j4...).
No, the first commit changed the `QString::utf8()` to `QString::toUtf8()`, the second changed `QTextString::read()` to `QTextStream::readAll()`. Could you attach your build output?
(In reply to Koos Vriezen from comment #5) > No, the first commit changed the `QString::utf8()` to `QString::toUtf8()`, > the second changed `QTextString::read()` to `QTextStream::readAll()`. > Could you attach your build output? Aah... crap. I made a mess while patching. Yes: 271ccae67d6efcb574e1791827d61a285b771687 fixes the build for me. Sorry for the noise...