Bug 373396 - Persistent padding around clock
Summary: Persistent padding around clock
Status: RESOLVED FIXED
Alias: None
Product: plasmashell
Classification: Plasma
Component: Digital Clock (show other bugs)
Version: master
Platform: Fedora RPMs Linux
: NOR normal
Target Milestone: 1.0
Assignee: Plasma Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-07 20:38 UTC by alexhollinghead
Modified: 2017-01-03 14:48 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Screenshot of issue (6.83 KB, image/png)
2016-12-07 20:38 UTC, alexhollinghead
Details

Note You need to log in before you can comment on or make changes to this bug.
Description alexhollinghead 2016-12-07 20:38:39 UTC
Created attachment 102673 [details]
Screenshot of issue

There's some odd padding around the digital clock. This is persistent regardless of font size as well as displaying date, seconds, or time zone. When time and date are stacked, padding is not present.
Comment 1 Roman Gilg 2016-12-09 12:47:40 UTC
I tried to replicate your issue, but couldn't get the margin of such an extreme extend as in your example. Sure that you are on the master branch? What Plasma version do you use? 5.8.x?

Anyway I did independently from your issue some optimization for the digital clock ui. Maybe your problem got fixed aswell: https://phabricator.kde.org/D3630
Comment 2 Wolfgang Bauer 2016-12-11 17:44:29 UTC
Looks like bug#370156, and seems to be related to the screen DPI.
It works fine with the standard 96 DPI here, but not wit 108 e.g.
Comment 3 Roman Gilg 2017-01-03 14:48:13 UTC
Git commit 1d362c4ae2e264a80c002ab6718c1b1d9437c20c by Roman Gilg.
Committed on 03/01/2017 at 14:37.
Pushed by romangilg into branch 'master'.

[Digital Clock] Bug fixes and ui code optimization

Summary:
- Fixed timezone size and alignment in vertical mode
- Instead of `Flow` use `Grid` for labels as it's simpler and gives better
  control over alignment
- Seperator in small horizontal mode centered between date and time and in
  height now dependent on label size
- Less empty space around time in small horizontal mode
- Binding loop and initlializting anchor errors fixed
- Elements now size completely down and have always the same ratio to each other
  with the time label being the largest
- Round functions removed since they disrupted the resizing for small sizes
- Introduce max font size values for text elements in panel mode
Related: bug 367585, bug 360059

Reviewers: #plasma, mart

Subscribers: mart, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3630

M  +206  -148  applets/digital-clock/package/contents/ui/DigitalClock.qml

https://commits.kde.org/plasma-workspace/1d362c4ae2e264a80c002ab6718c1b1d9437c20c